]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: renesas: fsi: Fix trigger stop ordering
authorbui duc phuc <phucduc.bui@gmail.com>
Tue, 9 Jun 2026 11:38:28 +0000 (18:38 +0700)
committerMark Brown <broonie@kernel.org>
Tue, 9 Jun 2026 23:33:46 +0000 (00:33 +0100)
Call fsi_stream_stop() before fsi_hw_shutdown(). This matches the existing
order in the suspend path.
This change ensures all register accesses during stream shutdown are fully
completed before disabling the clocks.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260609113836.45079-4-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/renesas/fsi.c

index 8cbd7acc26f49c53329e4005f7f41f6f4cfe9112..800ac40f9680d2f2e6a84866e1b340c1803e6270 100644 (file)
@@ -1586,10 +1586,10 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
                        ret = fsi_stream_transfer(io);
                break;
        case SNDRV_PCM_TRIGGER_STOP:
-               if (!ret)
-                       ret = fsi_hw_shutdown(fsi, dai->dev);
                fsi_stream_stop(fsi, io);
                fsi_stream_quit(fsi, io);
+               if (!ret)
+                       ret = fsi_hw_shutdown(fsi, dai->dev);
                break;
        }