[4091] Better odd check

diff --git a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
index 462945f88f391dff4d4dab13ac78209d0d586ad1..d39763d91e447074a63d3f20dfa1246020dbdf88 100644 (file)
--- a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
+++ b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
@@ -593,7 +593,7 @@ OptionDataParser::createOption(ConstElementPtr option_data) {
             // The decodeHex function expects that the string contains an
             // even number of digits. If we don't meet this requirement,
             // we have to insert a leading 0.
-            if (!data_param.empty() && data_param.length() % 2) {
+            if (!data_param.empty() && ((data_param.length() % 2) != 0)) {
                 data_param = data_param.insert(0, "0");
             }
             util::encode::decodeHex(data_param, binary);

diff --git a/src/lib/eval/token.cc b/src/lib/eval/token.cc
index 63aa7b7c8ff36eb96bdafcd0c3523d58152a008f..3592ffad35ec83046fbacc4081957af8940907a0 100644 (file)
--- a/src/lib/eval/token.cc
+++ b/src/lib/eval/token.cc
@@ -41,7 +41,7 @@ TokenHexString::evaluate(const Pkt& /*pkt*/, ValueStack& values) {
         // The decodeHex function expects that the string contains an
         // even number of digits. If we don't meet this requirement,
         // we have to insert a leading 0.
-        if (repr_.length() % 2) {
+        if ((repr_.length() % 2) != 0) {
             repr_ = repr_.insert(0, "0");
         }
         util::encode::decodeHex(repr_, binary);