]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Backport to gcc-9: PR92398: Fix testcase failure of pr72804.c
authorXionghu Luo <luoxhu@linux.ibm.com>
Tue, 10 Mar 2020 01:25:20 +0000 (20:25 -0500)
committerXionghu Luo <luoxhu@linux.ibm.com>
Tue, 10 Mar 2020 01:48:24 +0000 (20:48 -0500)
Backport the patch to fix failures on P9 and P8BE, P7LE for PR94036.
Tested pass on P9/P8/P7.
(gcc-8 is not needed as the test doesn't exists.)

P9LE generated instruction is not worse than P8LE.
mtvsrdd;xxlnot;stxv vs. not;not;std;std.
It can have longer latency, but latency via memory is not so critical,
and this does save decode and other resources.  It's hard to choose
which is best.  Update the test case to fix failures.

gcc/testsuite/ChangeLog:

2020-03-10  Luo Xiong Hu  <luoxhu@linux.ibm.com>

backport from master.
PR testsuite/94036

2019-12-02  Luo Xiong Hu  <luoxhu@linux.ibm.com>

PR testsuite/92398
* gcc.target/powerpc/pr72804.c: Split the store function to...
* gcc.target/powerpc/pr92398.h: ... this one.  New.
* gcc.target/powerpc/pr92398.p9+.c: New.
* gcc.target/powerpc/pr92398.p9-.c: New.
* lib/target-supports.exp (check_effective_target_p8): New.
(check_effective_target_p9+): New.

gcc/testsuite/ChangeLog
gcc/testsuite/gcc.target/powerpc/pr72804.c
gcc/testsuite/gcc.target/powerpc/pr92398.h [new file with mode: 0644]
gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c [new file with mode: 0644]
gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c [new file with mode: 0644]
gcc/testsuite/lib/target-supports.exp

index cb0d46f50c063c00415580ea898b9794a592940b..38efe35997fb799318a88e85280e7d566f9b0354 100644 (file)
@@ -1,3 +1,18 @@
+2020-03-10  Luo Xiong Hu  <luoxhu@linux.ibm.com>
+
+       backport from master.
+       PR testsuite/94036
+
+       2019-12-02  Luo Xiong Hu  <luoxhu@linux.ibm.com>
+
+       PR testsuite/92398
+       * gcc.target/powerpc/pr72804.c: Split the store function to...
+       * gcc.target/powerpc/pr92398.h: ... this one.  New.
+       * gcc.target/powerpc/pr92398.p9+.c: New.
+       * gcc.target/powerpc/pr92398.p9-.c: New.
+       * lib/target-supports.exp (check_effective_target_p8): New.
+       (check_effective_target_p9+): New.
+
 2020-03-05  Jakub Jelinek  <jakub@redhat.com>
 
        PR target/94046
index b83b6350d759c0a68c09cf22bf82950799492d19..c0711499ae567fc6db318060852ca834862b6411 100644 (file)
@@ -9,17 +9,7 @@ foo (__int128_t *src)
   return ~*src;
 }
 
-void
-bar (__int128_t *dst, __int128_t src)
-{
-  *dst =  ~src;
-}
 
-/* { dg-final { scan-assembler-times "not " 4 } } */
-/* { dg-final { scan-assembler-times "std " 2 } } */
-/* { dg-final { scan-assembler-times "ld " 2 } } */
-/* { dg-final { scan-assembler-not "lxvd2x" } } */
-/* { dg-final { scan-assembler-not "stxvd2x" } } */
-/* { dg-final { scan-assembler-not "xxpermdi" } } */
-/* { dg-final { scan-assembler-not "mfvsrd" } } */
-/* { dg-final { scan-assembler-not "mfvsrd" } } */
+/* { dg-final { scan-assembler-times {\mld\M} 2 } } */
+/* { dg-final { scan-assembler-times {\mnot\M} 2 } } */
+/* { dg-final { scan-assembler-not {\mlxvd2x\M} } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/pr92398.h b/gcc/testsuite/gcc.target/powerpc/pr92398.h
new file mode 100644 (file)
index 0000000..5a4a8bc
--- /dev/null
@@ -0,0 +1,17 @@
+/* This test code is included into pr92398.p9-.c and pr92398.p9+.c.
+   The two files have the tests for the number of instructions generated for
+   P9- versus P9+.
+
+   store generates difference instructions as below:
+   P9+: mtvsrdd;xxlnot;stxv.
+   P8/P7/P6 LE: not;not;std;std.
+   P8 BE: mtvsrd;mtvsrd;xxpermdi;xxlnor;stxvd2x.
+   P7/P6 BE: std;std;addi;lxvd2x;xxlnor;stxvd2x.
+   P9+ and P9- LE are expected, P6/P7/P8 BE are unexpected.  */
+
+void
+bar (__int128_t *dst, __int128_t src)
+{
+  *dst =  ~src;
+}
+
diff --git a/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c b/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c
new file mode 100644 (file)
index 0000000..a819c3f
--- /dev/null
@@ -0,0 +1,12 @@
+/* { dg-do compile { target { lp64 && p9+ } } } */
+/* { dg-require-effective-target powerpc_vsx_ok } */
+/* { dg-options "-O2 -mvsx" } */
+
+/* { dg-final { scan-assembler-times {\mmtvsrdd\M} 1 } } */
+/* { dg-final { scan-assembler-times {\mxxlnor\M} 1 } } */
+/* { dg-final { scan-assembler-times {\mstxv\M} 1 } } */
+/* { dg-final { scan-assembler-not {\mld\M} } } */
+/* { dg-final { scan-assembler-not {\mnot\M} } } */
+
+/* Source code for the test in pr92398.h */
+#include "pr92398.h"
diff --git a/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c b/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c
new file mode 100644 (file)
index 0000000..065ae73
--- /dev/null
@@ -0,0 +1,10 @@
+/* { dg-do compile { target { lp64 && {! p9+} } } } */
+/* { dg-require-effective-target powerpc_vsx_ok } */
+/* { dg-options "-O2 -mvsx" } */
+
+/* { dg-final { scan-assembler-times {\mnot\M} 2 { xfail be } } } */
+/* { dg-final { scan-assembler-times {\mstd\M} 2 { xfail { p8 && be } } } } */
+
+/* Source code for the test in pr92398.h */
+#include "pr92398.h"
+
index cda0f3d350bf67a52b071da8a305a95394169e62..ea9a50ccb27bc03195d10eaf088ca215fd855135 100644 (file)
@@ -2555,6 +2555,26 @@ proc check_effective_target_le { } {
     }]
 }
 
+# Return 1 if we're generating code for only power8 platforms.
+
+proc check_effective_target_p8 {  } {
+  return [check_no_compiler_messages_nocache p8 assembly {
+       #if !(!defined(_ARCH_PWR9) && defined(_ARCH_PWR8))
+       #error NO
+       #endif
+  } ""]
+}
+
+# Return 1 if we're generating code for power9 and future platforms.
+
+proc check_effective_target_p9+ {  } {
+  return [check_no_compiler_messages_nocache p9+ assembly {
+       #if !(defined(_ARCH_PWR9))
+       #error NO
+       #endif
+  } ""]
+}
+
 # Return 1 if we're generating 32-bit code using default options, 0
 # otherwise.