]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/misc/virt_ctrl: Fix incorrect trace event in read operation
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sun, 11 Jan 2026 18:49:15 +0000 (18:49 +0000)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Sun, 22 Feb 2026 21:52:29 +0000 (22:52 +0100)
The virt_ctrl_read() function currently invokes trace_virt_ctrl_write()
instead of trace_virt_ctrl_read(). This results in read operations
appearing as write operations in the trace output, which is misleading
during debugging and analysis.

Replace the incorrect trace call with the proper read-specific trace
event to accurately reflect the hardware behavior.

Fixes: 0791bc02b8fb ("m68k: add a system controller")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20260111184915.1363318-1-visitorckw@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/misc/virt_ctrl.c

index 40747925a290c1dd29ea6e593ecbefda61157ad9..9b82e97ffde7254854be3671fa15719d4c19de8c 100644 (file)
@@ -43,7 +43,7 @@ static uint64_t virt_ctrl_read(void *opaque, hwaddr addr, unsigned size)
         break;
     }
 
-    trace_virt_ctrl_write(s, addr, size, value);
+    trace_virt_ctrl_read(s, addr, size, value);
 
     return value;
 }