]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: say save-image-edit failed only when it does
authorJán Tomko <jtomko@redhat.com>
Fri, 10 Aug 2012 13:20:43 +0000 (15:20 +0200)
committerOsier Yang <jyang@redhat.com>
Tue, 14 Aug 2012 00:54:55 +0000 (08:54 +0800)
The common code for editing files in virsh-edit.c expects EDIT_DEFINE to
return 0 on failure. virDomainSaveImageDefineXML returns 0 on success.

tools/virsh-domain.c

index 33b1727f9486f68edfd6644c5b3625f4ef89d510..69e0133450df3dcb32873a54726776f66005fe31 100644 (file)
@@ -2973,7 +2973,7 @@ cmdSaveImageEdit(vshControl *ctl, const vshCmd *cmd)
                     "not changed.\n"), file);           \
     ret = true; goto edit_cleanup;
 #define EDIT_DEFINE \
-    virDomainSaveImageDefineXML(ctl->conn, file, doc_edited, define_flags)
+    (virDomainSaveImageDefineXML(ctl->conn, file, doc_edited, define_flags) == 0)
 #define EDIT_FREE /* */
 #include "virsh-edit.c"