]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vz: separate if conditions in vzEatCookie
authorJán Tomko <jtomko@redhat.com>
Fri, 2 Oct 2020 18:06:39 +0000 (20:06 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 5 Oct 2020 11:07:13 +0000 (13:07 +0200)
Create a separate scope where 'tmp' variable can be used.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/vz/vz_driver.c

index 40b1828eb24c5c76a953cfc4f08606b9c1a3ddd5..5b40f9a8350078d56407ff4e45b80200703d62da 100644 (file)
@@ -2806,26 +2806,28 @@ vzEatCookie(const char *cookiein, int cookieinlen, unsigned int flags)
                                       _("(_migration_cookie)"), &ctx)))
         goto error;
 
-    if ((flags & VZ_MIGRATION_COOKIE_SESSION_UUID)
-        && (!(tmp = virXPathString("string(./session-uuid[1])", ctx))
+    if (flags & VZ_MIGRATION_COOKIE_SESSION_UUID) {
+        if ((!(tmp = virXPathString("string(./session-uuid[1])", ctx))
             || (VIR_ALLOC_N(mig->session_uuid, VIR_UUID_BUFLEN) < 0)
             || (virUUIDParse(tmp, mig->session_uuid) < 0))) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("missing or malformed session-uuid element "
-                         "in migration data"));
-        VIR_FREE(tmp);
-        goto error;
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                           _("missing or malformed session-uuid element "
+                             "in migration data"));
+            VIR_FREE(tmp);
+            goto error;
+        }
     }
     VIR_FREE(tmp);
 
-    if ((flags & VZ_MIGRATION_COOKIE_DOMAIN_UUID)
-        && (!(tmp = virXPathString("string(./uuid[1])", ctx))
+    if (flags & VZ_MIGRATION_COOKIE_DOMAIN_UUID) {
+        if ((!(tmp = virXPathString("string(./uuid[1])", ctx))
             || (VIR_ALLOC_N(mig->uuid, VIR_UUID_BUFLEN) < 0)
             || (virUUIDParse(tmp, mig->uuid) < 0))) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("missing or malformed uuid element in migration data"));
-        VIR_FREE(tmp);
-        goto error;
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                           _("missing or malformed uuid element in migration data"));
+            VIR_FREE(tmp);
+            goto error;
+        }
     }
     VIR_FREE(tmp);