]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: milbeaut: convert from divider_round_rate() to divider_determine_rate()
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:29 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:25 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: 7b45988fcf78 ("clk: milbeaut: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/clk-milbeaut.c

index 4e3790b7fc9064484c20a068d0315b8fc8241290..45389db652e04e3c30c2a64da63b047b7922b8de 100644 (file)
@@ -403,10 +403,7 @@ static int m10v_clk_divider_determine_rate(struct clk_hw *hw,
                                                 val);
        }
 
-       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
-                                      divider->table, divider->width, divider->flags);
-
-       return 0;
+       return divider_determine_rate(hw, req, divider->table, divider->width, divider->flags);
 }
 
 static int m10v_clk_divider_set_rate(struct clk_hw *hw, unsigned long rate,