]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: virNetDevBridgeSet: split declarations
authorJán Tomko <jtomko@redhat.com>
Tue, 28 Jul 2020 18:09:22 +0000 (20:09 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 25 Aug 2020 17:03:12 +0000 (19:03 +0200)
Declare the variables at the beginning of the function,
then fill them up.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/util/virnetdevbridge.c

index e1ba119b8b2a76dc9ca7bed16b3061fcf4209d04..8ce1a07c41e14e2595992d11db816190724820e5 100644 (file)
@@ -119,6 +119,8 @@ static int virNetDevBridgeSet(const char *brname,
                               struct ifreq *ifr)      /* pre-filled bridge name */
 {
     g_autofree char *path = NULL;
+    unsigned long args[] = { 0, value, 0, 0 };
+    unsigned long paramid;
 
     path = g_strdup_printf(SYSFS_NET_DIR "%s/bridge/%s", brname, paramname);
 
@@ -129,7 +131,6 @@ static int virNetDevBridgeSet(const char *brname,
         VIR_DEBUG("Unable to set bridge %s %s via sysfs", brname, paramname);
     }
 
-    unsigned long paramid;
     if (STREQ(paramname, "stp_state")) {
         paramid = BRCTL_SET_BRIDGE_STP_STATE;
     } else if (STREQ(paramname, "forward_delay")) {
@@ -140,7 +141,8 @@ static int virNetDevBridgeSet(const char *brname,
                              brname, paramname);
         return -1;
     }
-    unsigned long args[] = { paramid, value, 0, 0 };
+
+    args[0] = paramid;
     ifr->ifr_data = (char*)&args;
     if (ioctl(fd, SIOCDEVPRIVATE, ifr) < 0) {
         virReportSystemError(errno,