]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: xml: Refactor cleanup in virXMLValidateAgainstSchema
authorPeter Krempa <pkrempa@redhat.com>
Thu, 4 Aug 2022 08:39:53 +0000 (10:39 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 2 Nov 2022 08:26:03 +0000 (09:26 +0100)
Use automatic freeing of the validator context to remove
'ret'/'cleanup:'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virxml.c

index ea43331dcc79783aacb7a388c4d0c90ec815067d..870ba194b037d9635fe4f60e267be1fa49ed1fa7 100644 (file)
@@ -1567,19 +1567,15 @@ int
 virXMLValidateAgainstSchema(const char *schemafile,
                             xmlDocPtr doc)
 {
-    virXMLValidator *validator = NULL;
-    int ret = -1;
+    g_autoptr(virXMLValidator) validator = NULL;
 
     if (!(validator = virXMLValidatorInit(schemafile)))
         return -1;
 
     if (virXMLValidatorValidate(validator, doc) < 0)
-        goto cleanup;
+        return -1;
 
-    ret = 0;
- cleanup:
-    virXMLValidatorFree(validator);
-    return ret;
+    return 0;
 }