board: tqma6: style fixes

fix checkpatch warnings

- WARNING: break is not useful after a return
- WARNING: Comparisons should place the constant
  on the right side of the test
- WARNING: please write a help paragraph that fully describes
  the config symbol with at least 2 lines

Signed-off-by: Paul Gerber <Paul.Gerber@tq-group.com>
Signed-off-by: Max Merchel <Max.Merchel@ew.tq-group.com>

diff --git a/board/tq/tqma6/Kconfig b/board/tq/tqma6/Kconfig
index b42c8e24ade3320621f2f33d17202cb909408476..599b3a72f7048c1da489cdb729c5b0baf0d2d89a 100644 (file)
--- a/board/tq/tqma6/Kconfig
+++ b/board/tq/tqma6/Kconfig
@@ -13,26 +13,29 @@ choice
        prompt "TQMa6 SoC variant"
        default TQMA6Q
        help
-         select the TQMa6 module variant. The variants differing in the used
+         select the TQMa6 module variant. The variants only differ in the used
          i.MX6 CPU type and DRAM
 
 config TQMA6Q
        bool "TQMa6Q / TQMa6D"
        depends on MX6Q
        help
-         select TQMa6Q / TQMa6D with i.MX6Q/D and 1GiB DRAM
+         select TQMa6Q / TQMa6D variant with i.MX6Q resp. i.MX6D
+         with 1GiB DRAM
 
 config TQMA6DL
        bool "TQMa6DL"
        depends on MX6DL
        help
-         select TQMa6DL with i.MX6DL and 1GiB DRAM
+         select TQMa6DL variant with i.MX6DL
+         with 1GiB DRAM
 
 config TQMA6S
        bool "TQMa6S"
        depends on MX6S
        help
-         select TQMa6S with i.MX6S and 512 MiB DRAM
+         select TQMa6S variant with i.MX6S
+         with 512 MiB DRAM
 
 endchoice
 
@@ -46,12 +49,14 @@ choice
 config TQMA6X_MMC_BOOT
        bool "MMC / SD Boot"
        help
-         Boot from eMMC / SD Card
+         Boot from
+         eMMC / SD Card
 
 config TQMA6X_SPI_BOOT
        bool "SPI NOR Boot"
        help
-         Boot from on board SPI NOR flash
+         Boot from
+         board SPI NOR flash
 
 endchoice
 
@@ -59,7 +64,8 @@ choice
        prompt "TQMa6 base board variant"
        default MBA6
        help
-         Select base board for TQMa6
+         Select the baseboard variant for the TQMa6 module.
+         By default the MBA6 starterkit is used.
 
 config MBA6
        bool "TQMa6 on MBa6 Starterkit"
@@ -80,7 +86,8 @@ config MBA6
 config WRU4
        bool "OHB WRU-IV"
        help
-         Select the OHB Systems AG WRU-IV baseboard.
+         Select the
+         OHB Systems AG WRU-IV baseboard.
 
 endchoice
 

diff --git a/board/tq/tqma6/tqma6.c b/board/tq/tqma6/tqma6.c
index a7317b9e761a9803512b052f0d68615b5231972f..83db2d1ad3831e7af941d454fc83674422c691c2 100644 (file)
--- a/board/tq/tqma6/tqma6.c
+++ b/board/tq/tqma6/tqma6.c
@@ -37,7 +37,6 @@ int dram_init(void)
 
 static const uint16_t tqma6_emmc_dsr = 0x0100;
 
-
 int board_early_init_f(void)
 {
        return tqma6_bb_board_early_init_f();
@@ -60,16 +59,12 @@ static const char *tqma6_get_boardname(void)
        switch ((cpurev & 0xFF000) >> 12) {
        case MXC_CPU_MX6SOLO:
                return "TQMa6S";
-               break;
        case MXC_CPU_MX6DL:
                return "TQMa6DL";
-               break;
        case MXC_CPU_MX6D:
                return "TQMa6D";
-               break;
        case MXC_CPU_MX6Q:
                return "TQMa6Q";
-               break;
        default:
                return "??";
        };

diff --git a/board/tq/tqma6/tqma6_mba6.c b/board/tq/tqma6/tqma6_mba6.c
index b8f76591006a36889694a1e2a66dd3c6375d49e8..630ffdd63a9c73ab4a9546b6911714701110716b 100644 (file)
--- a/board/tq/tqma6/tqma6_mba6.c
+++ b/board/tq/tqma6/tqma6_mba6.c
@@ -74,7 +74,7 @@ int board_mmc_get_env_dev(int devno)
         * the boot device first ...
         * Note: SDHC3 == idx2
         */
-       return (2 == devno) ? 0 : 1;
+       return (devno == 2) ? 0 : 1;
 }
 
 int board_phy_config(struct phy_device *phydev)