]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: Intel: catpt: Fix error path in hw_params()
authorCezary Rojewski <cezary.rojewski@intel.com>
Wed, 26 Nov 2025 09:55:20 +0000 (10:55 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 27 Nov 2025 11:41:14 +0000 (11:41 +0000)
Do not leave any resources hanging on the DSP side if
applying user settings fails.

Fixes: 768a3a3b327d ("ASoC: Intel: catpt: Optimize applying user settings")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20251126095523.3925364-4-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/catpt/pcm.c

index f15385683d9ce91db20e2cd5ca462734a4fe4d9a..9baaad13a273e09853696705778a8847e742c972 100644 (file)
@@ -417,8 +417,10 @@ static int catpt_dai_hw_params(struct snd_pcm_substream *substream,
                return CATPT_IPC_ERROR(ret);
 
        ret = catpt_dai_apply_usettings(dai, stream);
-       if (ret)
+       if (ret) {
+               catpt_ipc_free_stream(cdev, stream->info.stream_hw_id);
                return ret;
+       }
 
        stream->allocated = true;
        return 0;