]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: wcd939x: fix regmap leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 27 Nov 2025 13:50:57 +0000 (14:50 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 27 Nov 2025 16:36:37 +0000 (16:36 +0000)
The soundwire regmap that may be allocated during probe is not freed on
late probe failures.

Add the missing error handling.

Fixes: be2af391cea0 ("ASoC: codecs: Add WCD939x Soundwire devices driver")
Cc: stable@vger.kernel.org # 6.9
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251127135057.2216-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd939x-sdw.c

index d369100a245742f7c5c15cdd37edac06b376b8f4..da342a0c95a52bc9a872cfac23d7a874c7efc633 100644 (file)
@@ -1400,12 +1400,18 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id)
 
        ret = component_add(dev, &wcd_sdw_component_ops);
        if (ret)
-               return ret;
+               goto err_free_regmap;
 
        /* Set suspended until aggregate device is bind */
        pm_runtime_set_suspended(dev);
 
        return 0;
+
+err_free_regmap:
+       if (wcd->regmap)
+               regmap_exit(wcd->regmap);
+
+       return ret;
 }
 
 static int wcd9390_remove(struct sdw_slave *pdev)