]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: use skb_crc32c() in skb_crc32c_csum_help()
authorEric Biggers <ebiggers@google.com>
Mon, 19 May 2025 17:50:05 +0000 (10:50 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 21 May 2025 22:39:59 +0000 (15:39 -0700)
Instead of calling __skb_checksum() with a skb_checksum_ops struct that
does CRC32C, just call the new function skb_crc32c().  This is faster
and simpler.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://patch.msgid.link/20250519175012.36581-4-ebiggers@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c

index c27607b7f8b0bca31c580d561d3f8653e61743ba..e1e37dfb36283187aa3317109331173a709003c7 100644 (file)
@@ -3599,7 +3599,7 @@ EXPORT_SYMBOL(skb_checksum_help);
 #ifdef CONFIG_NET_CRC32C
 int skb_crc32c_csum_help(struct sk_buff *skb)
 {
-       __le32 crc32c_csum;
+       u32 crc;
        int ret = 0, offset, start;
 
        if (skb->ip_summed != CHECKSUM_PARTIAL)
@@ -3627,10 +3627,8 @@ int skb_crc32c_csum_help(struct sk_buff *skb)
        if (ret)
                goto out;
 
-       crc32c_csum = cpu_to_le32(~__skb_checksum(skb, start,
-                                                 skb->len - start, ~(__u32)0,
-                                                 crc32c_csum_stub));
-       *(__le32 *)(skb->data + offset) = crc32c_csum;
+       crc = ~skb_crc32c(skb, start, skb->len - start, ~0);
+       *(__le32 *)(skb->data + offset) = cpu_to_le32(crc);
        skb_reset_csum_not_inet(skb);
 out:
        return ret;