]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: soc_sdw_utils: drop bogus container_of() error handling
authorJohan Hovold <johan@kernel.org>
Fri, 19 Dec 2025 14:27:15 +0000 (15:27 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 22 Dec 2025 09:14:53 +0000 (09:14 +0000)
The dev_to_sdw_dev() helper uses container_of() to return the containing
soundwire device structure of its pointer argument and will never return
NULL.

Fixes: 4f8ef33dd44a ("ASoC: soc_sdw_utils: skip the endpoint that doesn't present")
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20251219142715.19254-4-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdw_utils/soc_sdw_utils.c

index f169d95895ea2b11880f362eec6346020b2a0e7a..bf382aa07e92f1062cde75222df30b077060e092 100644 (file)
@@ -1414,10 +1414,6 @@ static int is_sdca_endpoint_present(struct device *dev,
        }
 
        slave = dev_to_sdw_dev(sdw_dev);
-       if (!slave) {
-               ret = -EINVAL;
-               goto put_device;
-       }
 
        /* Make sure BIOS provides SDCA properties */
        if (!slave->sdca_data.interface_revision) {