media: i2c: Automatically select common options for lens drivers

In commit 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
a top level menu was added for sensor drivers so that all sensor drivers
would depend on I2C and so that MEDIA_CONTROLLER, V4L2_FWNODE and
VIDEO_V4L2_SUBDEV_API would be automatically selected for all sensor
drivers.

All lens drivers must depend on I2C and VIDEO_DEV and must select
MEDIA_CONTROLLER, V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API and most already
do, but e.g. VIDEO_V4L2_SUBDEV_API is not consistenly selected.

Change the "Lens drivers" menu into a menuconfig option with
the necessary depends and selects. This ensures that these options are
depended on / selected consistently and simplifies the Kconfig snippets
for the various lens voice coil drivers.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411061152.VKd9JYpa-lkp@intel.com/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 4b4c199da6ea4020c1c5d7a76bb2e20487d23dc2..6237fe804a5c89bb543d3b608412eb4c414b2b60 100644 (file)
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -766,24 +766,25 @@ config VIDEO_THP7312
 
 endmenu
 
-menu "Lens drivers"
-       visible if MEDIA_CAMERA_SUPPORT
+menuconfig VIDEO_CAMERA_LENS
+       bool "Lens drivers"
+       depends on MEDIA_CAMERA_SUPPORT && I2C
+       select MEDIA_CONTROLLER
+       select V4L2_FWNODE
+       select VIDEO_V4L2_SUBDEV_API
+       default y
+
+if VIDEO_CAMERA_LENS
 
 config VIDEO_AD5820
        tristate "AD5820 lens voice coil support"
-       depends on GPIOLIB && I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select V4L2_ASYNC
+       depends on GPIOLIB
        help
          This is a driver for the AD5820 camera lens voice coil.
          It is used for example in Nokia N900 (RX-51).
 
 config VIDEO_AK7375
        tristate "AK7375 lens voice coil support"
-       depends on I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select VIDEO_V4L2_SUBDEV_API
-       select V4L2_ASYNC
        help
          This is a driver for the AK7375 camera lens voice coil.
          AK7375 is a 12 bit DAC with 120mA output current sink
@@ -792,10 +793,7 @@ config VIDEO_AK7375
 
 config VIDEO_DW9714
        tristate "DW9714 lens voice coil support"
-       depends on GPIOLIB && I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select VIDEO_V4L2_SUBDEV_API
-       select V4L2_ASYNC
+       depends on GPIOLIB
        help
          This is a driver for the DW9714 camera lens voice coil.
          DW9714 is a 10 bit DAC with 120mA output current sink
@@ -804,10 +802,6 @@ config VIDEO_DW9714
 
 config VIDEO_DW9719
        tristate "DW9719 lens voice coil support"
-       depends on I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select VIDEO_V4L2_SUBDEV_API
-       select V4L2_ASYNC
        select V4L2_CCI_I2C
        help
          This is a driver for the DW9719 camera lens voice coil.
@@ -816,10 +810,6 @@ config VIDEO_DW9719
 
 config VIDEO_DW9768
        tristate "DW9768 lens voice coil support"
-       depends on I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select VIDEO_V4L2_SUBDEV_API
-       select V4L2_FWNODE
        help
          This is a driver for the DW9768 camera lens voice coil.
          DW9768 is a 10 bit DAC with 100mA output current sink
@@ -828,17 +818,13 @@ config VIDEO_DW9768
 
 config VIDEO_DW9807_VCM
        tristate "DW9807 lens voice coil support"
-       depends on I2C && VIDEO_DEV
-       select MEDIA_CONTROLLER
-       select VIDEO_V4L2_SUBDEV_API
-       select V4L2_ASYNC
        help
          This is a driver for the DW9807 camera lens voice coil.
          DW9807 is a 10 bit DAC with 100mA output current sink
          capability. This is designed for linear control of
          voice coil motors, controlled via I2C serial interface.
 
-endmenu
+endif
 
 menu "Flash devices"
        visible if MEDIA_CAMERA_SUPPORT