libmount: variable dereferenced before check [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/libmount/src/tab_update.c b/libmount/src/tab_update.c
index 3d2bd00e9e0e944e6c5bcb126ffd1a348827ae72..f049e42c06a34d3a4968aad229c51cd55c30e82b 100644 (file)
--- a/libmount/src/tab_update.c
+++ b/libmount/src/tab_update.c
@@ -718,7 +718,7 @@ int mnt_update_table(struct libmnt_update *upd, struct libmnt_lock *lc)
 
        assert(upd);
 
-       if (!upd->filename || !upd)
+       if (!upd || !upd->filename)
                return -EINVAL;
        if (!upd->ready)
                return 0;