]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kconfig: qconf: confine {begin,end}Group to constructor and destructor
authorMasahiro Yamada <masahiroy@kernel.org>
Sun, 29 Jun 2025 18:50:35 +0000 (03:50 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 26 Jul 2025 06:31:30 +0000 (15:31 +0900)
Call beginGroup() in the the constructor and endGroup() in the
destructor. This looks cleaner.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/qconf.cc
scripts/kconfig/qconf.h

index a7c98bbbd8acfbbac76b9daba47bc26332170837..f8992db1870ab461c121dec55b60d052cd9a5050 100644 (file)
@@ -37,6 +37,12 @@ QAction *ConfigMainWindow::saveAction;
 ConfigSettings::ConfigSettings()
        : QSettings("kernel.org", "qconf")
 {
+       beginGroup("/kconfig/qconf");
+}
+
+ConfigSettings::~ConfigSettings()
+{
+       endGroup();
 }
 
 /**
@@ -1829,7 +1835,6 @@ int main(int ac, char** av)
        configApp = new QApplication(ac, av);
 
        configSettings = new ConfigSettings();
-       configSettings->beginGroup("/kconfig/qconf");
        v = new ConfigMainWindow();
 
        //zconfdump(stdout);
@@ -1837,7 +1842,6 @@ int main(int ac, char** av)
        v->show();
        configApp->exec();
 
-       configSettings->endGroup();
        delete configSettings;
        delete v;
        delete configApp;
index 62ab3286d04f753b93a086a74e98eb2d3af88884..ab4e51f12914cc0f4a79925fe5aaa4c862996bba 100644 (file)
@@ -24,6 +24,7 @@ class ConfigMainWindow;
 class ConfigSettings : public QSettings {
 public:
        ConfigSettings();
+       ~ConfigSettings(void);
        QList<int> readSizes(const QString& key, bool *ok);
        bool writeSizes(const QString& key, const QList<int>& value);
 };