Prepare a zone for shutting down when deleting it from a view

After b171cacf4f0123ba96bef6eedfc92dfb608db6b7, a zone object can
remain in the memory for a while, until garbage collection is run.
Setting the DNS_ZONEFLG_EXITING flag should prevent the zone
maintenance function from running while it's in that state.
Otherwise, a secondary zone could initiate a zone transfer after
it had been deleted.

diff --git a/lib/dns/include/dns/zone.h b/lib/dns/include/dns/zone.h
index 4b4cf9388c90b9be7638adc143fbe9a647b2887f..fc3f601028614be94e2f9696bd311e633822c6f6 100644 (file)
--- a/lib/dns/include/dns/zone.h
+++ b/lib/dns/include/dns/zone.h
@@ -1718,6 +1718,20 @@ dns_zone_findkeys(dns_zone_t *zone, dns_db_t *db, dns_dbversion_t *ver,
  *\li  Error
  */
 
+void
+dns_zone_prepare_shutdown(dns_zone_t *zone);
+/*%<
+ * Prepare a zone for shutdown by setting the DNS_ZONEFLG_EXITING flag even
+ * before the final reference is detached. Useful, because the zone object can
+ * be kept around with a valid reference from the zonetable until qp garbage
+ * collector runs, and we don't want, for example, zone maintenance to happen
+ * while waiting for it. Note that the zone can not be used normally again after
+ * this function is called.
+ *
+ * Requires:
+ *\li  'zone' to be a valid initialised zone.
+ */
+
 void
 dns_zonemgr_create(isc_mem_t *mctx, isc_nm_t *netmgr, dns_zonemgr_t **zmgrp);
 /*%<

diff --git a/lib/dns/view.c b/lib/dns/view.c
index 80542d6c461a8bd1cae8d59dd51883b483bb68ad..489fc70a1b6bbf623bc5cff69d0add12b5317f30 100644 (file)
--- a/lib/dns/view.c
+++ b/lib/dns/view.c
@@ -711,6 +711,8 @@ dns_view_delzone(dns_view_t *view, dns_zone_t *zone) {
 
        REQUIRE(DNS_VIEW_VALID(view));
 
+       dns_zone_prepare_shutdown(zone);
+
        rcu_read_lock();
        zonetable = rcu_dereference(view->zonetable);
        if (zonetable != NULL) {

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index eed65a66a8dc2949f158bb89d78e9911740308f8..1ee46b7565ce0dd1e0052029c73f734320c78758 100644 (file)
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -6545,6 +6545,15 @@ failure:
        return result;
 }
 
+void
+dns_zone_prepare_shutdown(dns_zone_t *zone) {
+       REQUIRE(DNS_ZONE_VALID(zone));
+
+       LOCK_ZONE(zone);
+       DNS_ZONE_SETFLAG(zone, DNS_ZONEFLG_EXITING);
+       UNLOCK_ZONE(zone);
+}
+
 /*%
  * Find DNSSEC keys used for signing zone with dnssec-policy. Load these keys
  * into 'keys'. Requires KASP to be locked.