remove workaround for old Polycom firmware SUBSCRIBE requests

add workaround for new Polycom firmware SUBSCRIBE requests (bug is known to exist in 2.0.1 firmware)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index b5ce792c64f6386a72d67691c505353eea050bc1..9c744edc7050bc2567a9e111396c1cdae5d31aba 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -10952,7 +10952,10 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
                        if (!strcmp(event, "presence") || !strcmp(event, "dialog")) { /* Presence, RFC 3842 */
 
                                /* Header from Xten Eye-beam Accept: multipart/related, application/rlmi+xml, application/pidf+xml, application/xpidf+xml */
-                               if (strstr(accept, "application/pidf+xml")) {
+                               /* don't supply pidf+xml to Polycom phones until they fix their firmware to
+                                  parse it properly
+                               */
+                               if (strstr(accept, "application/pidf+xml") && !strstr(p->useragent, "Polycom")) {
                                        p->subscribed = PIDF_XML;         /* RFC 3863 format */
                                } else if (strstr(accept, "application/dialog-info+xml")) {
                                        p->subscribed = DIALOG_INFO_XML;
@@ -10961,8 +10964,6 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
                                        p->subscribed = CPIM_PIDF_XML;    /* RFC 3863 format */
                                } else if (strstr(accept, "application/xpidf+xml")) {
                                        p->subscribed = XPIDF_XML;        /* Early pre-RFC 3863 format with MSN additions (Microsoft Messenger) */
-                               } else if (strstr(p->useragent, "Polycom")) {
-                                       p->subscribed = XPIDF_XML;        /*  Polycoms subscribe for "event: dialog" but don't include an "accept:" header */
                                } else {
                                        /* Can't find a format for events that we know about */
                                        transmit_response(p, "489 Bad Event", req);