ALSA: pcm: Add sanity NULL check for the default mmap fault handler

commit d2913a07d9037fe7aed4b7e680684163eaed6bc4 upstream.

A driver might allow the mmap access before initializing its
runtime->dma_area properly.  Add a proper NULL check before passing to
virt_to_page() for avoiding a panic.

Reported-by: syzbot+4bf62a7b1d0f4fdb7ae2@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20241120141104.7060-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 3b87f6cb5bb0452cb0d2a67958e2be0b0f28cd6f..464b99b432d3339e634cb5b815ba28491ee57428 100644 (file)
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3757,9 +3757,11 @@ static vm_fault_t snd_pcm_mmap_data_fault(struct vm_fault *vmf)
                return VM_FAULT_SIGBUS;
        if (substream->ops->page)
                page = substream->ops->page(substream, offset);
-       else if (!snd_pcm_get_dma_buf(substream))
+       else if (!snd_pcm_get_dma_buf(substream)) {
+               if (WARN_ON_ONCE(!runtime->dma_area))
+                       return VM_FAULT_SIGBUS;
                page = virt_to_page(runtime->dma_area + offset);
-       else
+       } else
                page = snd_sgbuf_get_page(snd_pcm_get_dma_buf(substream), offset);
        if (!page)
                return VM_FAULT_SIGBUS;