]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: wm8731: Remove unnecessary NULL check before clk_prepare_enable/clk_dis...
authorChen Ni <nichen@iscas.ac.cn>
Mon, 26 Jan 2026 07:35:28 +0000 (15:35 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 26 Jan 2026 21:22:49 +0000 (21:22 +0000)
clk_prepare_enable() and clk_disable_unprepare() already checked NULL
clock parameter.
Remove unneeded NULL check for wm8731->mclk here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260126073528.1826406-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8731.c

index a03bbde5d8527051b20e572e5ad349d264ad9c4d..a2f0e2f5c407074f0cb6dca79d09b9178acf8c42 100644 (file)
@@ -471,11 +471,9 @@ static int wm8731_set_bias_level(struct snd_soc_component *component,
 
        switch (level) {
        case SND_SOC_BIAS_ON:
-               if (wm8731->mclk) {
-                       ret = clk_prepare_enable(wm8731->mclk);
-                       if (ret)
-                               return ret;
-               }
+               ret = clk_prepare_enable(wm8731->mclk);
+               if (ret)
+                       return ret;
                break;
        case SND_SOC_BIAS_PREPARE:
                break;
@@ -494,8 +492,7 @@ static int wm8731_set_bias_level(struct snd_soc_component *component,
                snd_soc_component_write(component, WM8731_PWR, reg | 0x0040);
                break;
        case SND_SOC_BIAS_OFF:
-               if (wm8731->mclk)
-                       clk_disable_unprepare(wm8731->mclk);
+               clk_disable_unprepare(wm8731->mclk);
                snd_soc_component_write(component, WM8731_PWR, 0xffff);
                regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies),
                                       wm8731->supplies);