]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Ranger cache - always use range_from_dom when updating.
authorAndrew MacLeod <amacleod@redhat.com>
Tue, 10 Jan 2023 18:40:56 +0000 (13:40 -0500)
committerAndrew MacLeod <amacleod@redhat.com>
Wed, 1 Feb 2023 14:26:02 +0000 (09:26 -0500)
When updating an existing range, if we dont query the dom tree, we can
get the global range instead of a proper range on some incoming edges
which cause the range to not be refined properly.

PR tree-optimization/108356
gcc/
* gimple-range-cache.cc (ranger_cache::range_on_edge): Always
do a search of the DOM tree for a range.

gcc/testsuite/
* gcc.dg/pr108356.c: New.

gcc/gimple-range-cache.cc
gcc/testsuite/gcc.dg/pr108356.c [new file with mode: 0644]

index a8202f0e8951b4bb88c7aaa62cee20c7257e8d36..20c444bc4f4fd492b661f744c8ca682fa0804043 100644 (file)
@@ -998,7 +998,7 @@ bool
 ranger_cache::range_on_edge (vrange &r, edge e, tree expr)
 {
   if (gimple_range_ssa_p (expr))
-    return edge_range (r, e, expr, RFD_NONE);
+    return edge_range (r, e, expr, RFD_READ_ONLY);
   return get_tree_range (r, expr, NULL);
 }
 
diff --git a/gcc/testsuite/gcc.dg/pr108356.c b/gcc/testsuite/gcc.dg/pr108356.c
new file mode 100644 (file)
index 0000000..1df6b27
--- /dev/null
@@ -0,0 +1,23 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+
+char a;
+static char c = 3;
+char d;
+void foo();
+short(b)(short e, short f) { return e + f; }
+int main() {
+  unsigned g = 0;
+  if (c)
+    ;
+  else
+    foo();
+  for (; g < 2; g = b(g, 2)) {
+    d = g ? 0 : a;
+    if (g)
+      c = 0;
+  }
+}
+
+
+/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */