]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
e2freefrag: require that the chunksize must be greater than 0
authorTheodore Ts'o <tytso@mit.edu>
Mon, 26 May 2025 16:36:07 +0000 (12:36 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 9 Jun 2025 20:55:18 +0000 (16:55 -0400)
"e2freefrag -c 0" doesn't make much sense, so abort with an error
message if the user specifies a zero chunksize.

Addresses-Coverity-Bug: 1633767
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
(cherry picked from commit 3e059df08de94abde1ddd82008d0658584a35e5e)

misc/e2freefrag.c

index 63a3d435103e1f0b631629fe9b3643c52967dfce..c66e8f22f3d869767c3222e2941996176cf8fa44 100644 (file)
@@ -405,7 +405,7 @@ int main(int argc, char *argv[])
                switch (c) {
                case 'c':
                        chunk_info.chunkbytes = strtoull(optarg, &end, 0);
-                       if (*end != '\0') {
+                       if (*end != '\0' || chunk_info.chunkbytes == 0) {
                                fprintf(stderr, "%s: bad chunk size '%s'\n",
                                        progname, optarg);
                                usage(progname);