]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Remove coverity[negative_returns] annotation
authorAndrea Bolognani <abologna@redhat.com>
Mon, 19 Jun 2017 08:23:17 +0000 (16:23 +0800)
committerAndrea Bolognani <abologna@redhat.com>
Tue, 20 Jun 2017 01:39:56 +0000 (09:39 +0800)
It was added in commit 6c2e4c3856c8ed48c378bf1bf357cab46271a47a
so that Coverity would not complain about passing -1 to
qemuDomainDetachThisHostDevice(), but the function in question
has changed since and so the annotation doesn't apply anymore.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/qemu/qemu_hotplug.c

index 244dd5e605e65b3813e4eea2aee01f06552acb5c..5247c065711d85084aa44e89eafe1480b8b1e607 100644 (file)
@@ -5007,7 +5007,6 @@ qemuDomainDetachNetDevice(virQEMUDriverPtr driver,
     detach = vm->def->nets[detachidx];
 
     if (virDomainNetGetActualType(detach) == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
-        /* coverity[negative_returns] */
         ret = qemuDomainDetachThisHostDevice(driver, vm,
                                              virDomainNetGetActualHostdev(detach));
         goto cleanup;