Bug 250547: Make FlagTypes use INNER JOIN instead of comma operator.

Patch by Tomas Kopal <Tomas.Kopal@altap.cz>
r=jouni, a=justdave

diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm
index a428d5389acc45c284603355cc8d23079fffc76e..f1cb00c5da098576a59742583bfc7ef03b5cb5c2 100644 (file)
--- a/Bugzilla/FlagType.pm
+++ b/Bugzilla/FlagType.pm
@@ -326,8 +326,8 @@ sub sqlify_criteria {
         
         # Add inclusions to the query, which simply involves joining the table
         # by flag type ID and target product/component.
-        push(@$tables, ", flaginclusions");
-        push(@criteria, "flagtypes.id = flaginclusions.type_id");
+        push(@$tables, "INNER JOIN flaginclusions ON " .
+                       "flagtypes.id = flaginclusions.type_id");
         push(@criteria, "(flaginclusions.product_id = $product_id " . 
                         " OR flaginclusions.product_id IS NULL)");
         push(@criteria, "(flaginclusions.component_id = $component_id " .