]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: soc-core: add lockdep_assert_held() at snd_soc_unregister_dai()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 28 Jan 2026 02:19:00 +0000 (02:19 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 28 Jan 2026 19:31:52 +0000 (19:31 +0000)
snd_soc_register_dai()           has  lockdep_assert_held() (A), but
snd_soc_unregister_dai() doesn't have lockdep_assert_held() (B).

void snd_soc_unregister_dai(...)
{
(B) dev_dbg(...);
list_del(...);
}

struct snd_soc_dai *snd_soc_register_dai(...)
{
...
(A) lockdep_assert_held(&client_mutex);
...
}

Both functions should be called with client_mutex lock.
Add missing lockdep_assert_held() at snd_soc_unregister_dai().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87jyx21nu4.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index 355ccc95f28ba3cb63b94f646d0b7db328cd1123..5811d053ce7a005392d55415074fbcf73a12503b 100644 (file)
@@ -2679,6 +2679,8 @@ static inline char *fmt_multiple_name(struct device *dev,
 
 void snd_soc_unregister_dai(struct snd_soc_dai *dai)
 {
+       lockdep_assert_held(&client_mutex);
+
        dev_dbg(dai->dev, "ASoC: Unregistered DAI '%s'\n", dai->name);
        list_del(&dai->list);
 }