]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/imagination: Fix missing argument in pvr_power_fw_{en,dis}able()
authorJavier Martinez Canillas <javierm@redhat.com>
Tue, 19 May 2026 13:12:05 +0000 (15:12 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 20 May 2026 08:52:10 +0000 (10:52 +0200)
Commit 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised")
dropped by mistake the last argument of the functions pvr_power_fw_enable()
and pvr_power_fw_disable(), leading to the following compile error:

  CC [M]  drivers/gpu/drm/imagination/pvr_power.o
drivers/gpu/drm/imagination/pvr_power.c: In function ‘pvr_power_device_suspend’:
drivers/gpu/drm/imagination/pvr_power.c:382:23: error: too few arguments to function ‘pvr_power_fw_disable’; expected 3, have 2
  382 |                 err = pvr_power_fw_disable(pvr_dev, false);
      |                       ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imagination/pvr_power.c:93:1: note: declared here
   93 | pvr_power_fw_disable(struct pvr_device *pvr_dev, bool hard_reset, bool rpm_suspend)
      | ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imagination/pvr_power.c: In function ‘pvr_power_device_resume’:
drivers/gpu/drm/imagination/pvr_power.c:412:23: error: too few arguments to function ‘pvr_power_fw_enable’; expected 2, have 1
  412 |                 err = pvr_power_fw_enable(pvr_dev);
      |                       ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/imagination/pvr_power.c:122:1: note: declared here
  122 | pvr_power_fw_enable(struct pvr_device *pvr_dev, bool rpm_resume)
      | ^~~~~~~~~~~~~~~~~~~
make[6]: *** [scripts/Makefile.build:289: drivers/gpu/drm/imagination/pvr_power.o] Error 1
make[5]: *** [scripts/Makefile.build:548: drivers/gpu/drm/imagination] Error 2
make[4]: *** [scripts/Makefile.build:548: drivers/gpu/drm] Error 2
make[3]: *** [scripts/Makefile.build:548: drivers/gpu] Error 2
make[2]: *** [scripts/Makefile.build:548: drivers] Error 2
make[1]: *** [/home/javier/devel/linux/Makefile:2141: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Fixes: 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised")
Reviewed-by: Brajesh Gupta <brajesh.gupta@imgtec.com>
Link: https://patch.msgid.link/20260519131239.1291732-1-javierm@redhat.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/imagination/pvr_power.c

index 0ed9e7be604b5e40f5c2031ff1167fb20b372c49..a71d5b35601e7b996428312028a4c0542a5b1350 100644 (file)
@@ -379,7 +379,7 @@ pvr_power_device_suspend(struct device *dev)
                return -EIO;
 
        if (READ_ONCE(pvr_dev->fw_dev.initialised)) {
-               err = pvr_power_fw_disable(pvr_dev, false);
+               err = pvr_power_fw_disable(pvr_dev, false, true);
                if (err)
                        goto err_drm_dev_exit;
        }
@@ -409,7 +409,7 @@ pvr_power_device_resume(struct device *dev)
                goto err_drm_dev_exit;
 
        if (READ_ONCE(pvr_dev->fw_dev.initialised)) {
-               err = pvr_power_fw_enable(pvr_dev);
+               err = pvr_power_fw_enable(pvr_dev, true);
                if (err)
                        goto err_power_off;
        }