build: ensure factor links the iconv library

* src/local.mk (src_factor_LDADD): Append $(LIBICONV).
* crg.mk (sc_check-I18N-AUTHORS): A new syntax check rule
to ensure we add LIBICONV where appropriate.
* THANKS.in: Add the reporter.
Reported by Christian Jullien
Syntax check suggested by Jim Meyering

diff --git a/THANKS.in b/THANKS.in
index 504daf3abb92e678754362b75b1fb0609fdbd058..016a41eb7892232a89b48a2a6e3e5e7a7bd709a4 100644 (file)
--- a/THANKS.in
+++ b/THANKS.in
@@ -118,6 +118,7 @@ Chris Sylvain                       csylvain@umm.edu
 Chris Yeo                           cyeo@biking.org
 Christi Alice Scarborough           christi@chiark.greenend.org.uk
 Christian Harkort                   christian.harkort@web.de
+Christian Jullien                   eligis@orange.fr
 Christian Krackowizer               ckrackowiz@std.schuler-ag.com
 Christian Rose                      menthos@menthos.com
 Christian von Roques                roques@pond.sub.org

diff --git a/cfg.mk b/cfg.mk
index 43fb22fea7af61bf9fae6c345f08dd0379267daa..40ece55d33fbfd2c1750d0db0f00c541305508ec 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,6 +181,14 @@ sc_check-AUTHORS: $(all_programs)
          && diff $(au_actual) $(au_dotdot) \
          && rm -f $(au_actual) $(au_dotdot)
 
+# Ensure programs with authors with non ASCII names link with LIBICONV
+sc_check-I18N-AUTHORS:
+       @(cd $(srcdir)/src &&                           \
+         for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
+           grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
+             /dev/null || { echo FAIL $$i; exit 1; };            \
+         done)
+
 # Look for lines longer than 80 characters, except omit:
 # - program-generated long lines in diff headers,
 # - tests involving long checksum lines, and

diff --git a/src/local.mk b/src/local.mk
index 6a01ef1c74aec17fd3063d1881c97f7c13660827..f40f68175285af519719c3298a46a2bac24a1bbf 100644 (file)
--- a/src/local.mk
+++ b/src/local.mk
@@ -277,6 +277,7 @@ src_cat_LDADD += $(LIBICONV)
 src_cp_LDADD += $(LIBICONV)
 src_df_LDADD += $(LIBICONV)
 src_du_LDADD += $(LIBICONV)
+src_factor_LDADD += $(LIBICONV)
 src_getlimits_LDADD += $(LIBICONV)
 src_printf_LDADD += $(LIBICONV)
 src_ptx_LDADD += $(LIBICONV)