]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: fsl-edma: Remove redundant dev_err() for platform_get_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Fri, 1 Sep 2023 07:11:14 +0000 (15:11 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 4 Oct 2023 13:47:01 +0000 (19:17 +0530)
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
to platform_get_irq*()") and commit 2043727c2882 ("driver core:
platform: Make use of the helper function dev_err_probe()"), there is
no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as it is
going to display an appropriate error message in case of a failure.

Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230901071115.1322000-1-ruanjinjie@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-edma-main.c

index 11da143955b3bd9a0cabaa75dc39c0e79f8ed0b9..78ceaa71675fe798b93515487bb9cccf4a849b14 100644 (file)
@@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
 
                /* request channel irq */
                fsl_chan->txirq = platform_get_irq(pdev, i);
-               if (fsl_chan->txirq < 0) {
-                       dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i);
+               if (fsl_chan->txirq < 0)
                        return  -EINVAL;
-               }
 
                ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
                        fsl_edma3_tx_handler, IRQF_SHARED,