s3:utils: smbget fix a memory leak

Using smbget to download files recursively (-R).

If smbget found that a file is already existed in the destination,
smbget would said 'File exists', return early, and 'newname' allocated
memory is never freed, this is found by valgrind.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15403

Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jun 28 07:02:34 UTC 2023 on atb-devel-224

(cherry picked from commit afbed653526b572f7309e67ed742a76ef7b2b8ec)

Autobuild-User(v4-17-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-17-test): Wed Jun 28 21:03:31 UTC 2023 on sn-devel-184

diff --git a/source3/utils/smbget.c b/source3/utils/smbget.c
index 3e7c5687d83e9d6912b7794f4c5bf849d723a46e..b568429d0e99509abe317190b24809d9385256e4 100644 (file)
--- a/source3/utils/smbget.c
+++ b/source3/utils/smbget.c
@@ -264,6 +264,7 @@ static bool smb_download_dir(const char *base, const char *name, int resume)
                if (!ok) {
                        fprintf(stderr, "Failed to download %s: %s\n",
                                newname, strerror(errno));
+                       free(newname);
                        free(tmpname);
                        return false;
                }