docs: env variable handling behaviour consistent between OS X and Linux, thus remove...

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15585

diff --git a/coregrind/m_libcproc.c b/coregrind/m_libcproc.c
index e573af591c063e386298c915d2244ea71c6edb3a..f314b55eea88e286f8e65f5abf28f21916bf2c50 100644 (file)
--- a/coregrind/m_libcproc.c
+++ b/coregrind/m_libcproc.c
@@ -230,14 +230,6 @@ static void mash_colon_env(HChar *varp, const HChar *remove_pattern)
 void VG_(env_remove_valgrind_env_stuff)(HChar** envp, Bool ro_strings,
                                         void (*free_fn) (void *) )
 {
-
-#if defined(VGO_darwin)
-
-   // Environment cleanup is also handled during parent launch 
-   // in vg_preloaded.c:vg_cleanup_env().
-
-#endif
-
    Int i;
    HChar* ld_preload_str = NULL;
    HChar* ld_library_path_str = NULL;

diff --git a/docs/internals/Darwin-notes.txt b/docs/internals/Darwin-notes.txt
index f526c4fe829784c7ab783ddfa22aef8c9490036a..85c9e8e48ad24244cfcf7cd82113b72a2c081cde 100644 (file)
--- a/docs/internals/Darwin-notes.txt
+++ b/docs/internals/Darwin-notes.txt
@@ -69,13 +69,6 @@ Valgrind-developer notes, todos re the MacOSX port
   - PRE(sys_posix_spawn) completely ignores signal issues, and
     also ignores the file_actions argument
 
-* env var handling w/ exec on Darwin: is there something odd?  Compare
-  "valgrind env" on Darwin and Linux.  On the former there are
-  settings VALGRIND_LIB and VALGRIND_LIB_INNER, but not for the
-  former.
-  There's a suspicious-looking "#if defined(VGO_darwin)" in 
-  VG_(env_remove_valgrind_env_stuff).  Maybe related?
-
 * Cleanups: sort wrappers in syswrap-darwin.c and priv_syswrap-darwin.h
   alphabetically.  Also, some aren't properly implemented -- check and
   print warnings