media: mediatek: encoder: Fix uninitialized scalar variable issue

UNINIT checker finds some instances of variables that are used
without being initialized, for example using the uninitialized
value enc_result.is_key_frm can result in unpredictable behavior,
so initialize these variables after declaring.

Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Irui Wang <irui.wang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc.c b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc.c
index 6faf3f659e751097f31be23c46d8cf586306e889..b3a0a1d8b7a8e923e41c37f536506e73bae028c8 100644 (file)
--- a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc.c
+++ b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc.c
@@ -850,7 +850,7 @@ static void vb2ops_venc_buf_queue(struct vb2_buffer *vb)
 static int vb2ops_venc_start_streaming(struct vb2_queue *q, unsigned int count)
 {
        struct mtk_vcodec_enc_ctx *ctx = vb2_get_drv_priv(q);
-       struct venc_enc_param param;
+       struct venc_enc_param param = { };
        int ret;
        int i;
 
@@ -1004,7 +1004,7 @@ static int mtk_venc_encode_header(void *priv)
        int ret;
        struct vb2_v4l2_buffer *src_buf, *dst_buf;
        struct mtk_vcodec_mem bs_buf;
-       struct venc_done_result enc_result;
+       struct venc_done_result enc_result = { };
 
        dst_buf = v4l2_m2m_dst_buf_remove(ctx->m2m_ctx);
        if (!dst_buf) {
@@ -1125,7 +1125,7 @@ static void mtk_venc_worker(struct work_struct *work)
        struct vb2_v4l2_buffer *src_buf, *dst_buf;
        struct venc_frm_buf frm_buf;
        struct mtk_vcodec_mem bs_buf;
-       struct venc_done_result enc_result;
+       struct venc_done_result enc_result = { };
        int ret, i;
 
        /* check dst_buf, dst_buf may be removed in device_run