]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: fsl_asrc: fix m2m_init error path to use goto instead of bare return
authorShengjiu Wang <shengjiu.wang@nxp.com>
Wed, 15 Jul 2026 02:47:57 +0000 (10:47 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 19 Jul 2026 21:25:10 +0000 (22:25 +0100)
When fsl_asrc_m2m_init() fails in fsl_asrc_probe(), the code did a
bare return ret, bypassing pm_runtime_disable() in err_pm_get_sync.
Use goto err_pm_get_sync to ensure proper cleanup on failure.

Fixes: 286d658477a4 ("ASoC: fsl_asrc: register m2m platform device")
Cc: stable@vger.kernel.org
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://patch.msgid.link/20260715024758.1252801-2-shengjiu.wang@oss.nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_asrc.c

index 5fda9b647c7049a85c42845433773defb377a6a8..f23c210322872c74dd2437ce25f8c38d2e4bb67b 100644 (file)
@@ -1419,7 +1419,7 @@ static int fsl_asrc_probe(struct platform_device *pdev)
        ret = fsl_asrc_m2m_init(asrc);
        if (ret) {
                dev_err(&pdev->dev, "failed to init m2m device %d\n", ret);
-               return ret;
+               goto err_pm_get_sync;
        }
 
        return 0;