]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
general: Improve logging levels of some log messages.
authorNaveen Albert <asterisk@phreaknet.org>
Fri, 22 Jul 2022 20:57:05 +0000 (20:57 +0000)
committerGeorge Joseph <gjoseph@digium.com>
Mon, 1 Aug 2022 16:04:02 +0000 (11:04 -0500)
Adjusts some logging levels to be more or less important,
that is more prominent when actual problems occur and less
prominent for less noteworthy things.

ASTERISK-30153 #close

Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b

apps/app_stack.c
apps/app_voicemail.c
channels/chan_dahdi.c
channels/chan_iax2.c
main/manager.c
main/stasis.c
res/res_pjsip/config_transport.c
res/res_pjsip/pjsip_options.c

index 557c6f160fb4a9a9b1a345ad4e5d8605739e3290..a84a45c1b4b4a1839f217bd38631de0ac65a953c 100644 (file)
@@ -1076,7 +1076,7 @@ static int gosub_run(struct ast_channel *chan, const char *sub_args, int ignore_
                                ast_channel_name(chan), app_gosub, sub_args,
                                S_OR(pbx_builtin_getvar_helper(chan, "GOSUB_RETVAL"), ""));
                } else {
-                       ast_log(LOG_NOTICE, "%s Abnormal '%s(%s)' exit.  Popping routine return locations.\n",
+                       ast_log(LOG_WARNING, "%s Abnormal '%s(%s)' exit.  Popping routine return locations.\n",
                                ast_channel_name(chan), app_gosub, sub_args);
                        balance_stack(chan);
                        pbx_builtin_setvar_helper(chan, "GOSUB_RETVAL", "");
index 5436c87e23fdb7595390ec50d20014fd8f916d94..510e15d7880e9845320badf05167767bbdc93c07 100644 (file)
@@ -11197,12 +11197,14 @@ static int vm_authenticate(struct ast_channel *chan, char *mailbox, int mailbox_
                        password[0] = '\0';
                } else {
                        if (ast_streamfile(chan, vm_password, ast_channel_language(chan))) {
-                               ast_log(AST_LOG_WARNING, "Unable to stream password file\n");
+                               if (!ast_check_hangup(chan)) {
+                                       ast_log(AST_LOG_WARNING, "Unable to stream password file\n");
+                               }
                                free_user(vmu);
                                return -1;
                        }
                        if (ast_readstring(chan, password, sizeof(password) - 1, 2000, 10000, "#") < 0) {
-                               ast_log(AST_LOG_WARNING, "Unable to read password\n");
+                               ast_log(AST_LOG_NOTICE, "Unable to read password\n");
                                free_user(vmu);
                                return -1;
                        } else if (password[0] == '*') {
index 5adb797a5aae2fdff433e746cf5e664dbc5b1bc9..8ce0526f4dd32429bf457fdc86f08745171da0ce 100644 (file)
@@ -19411,7 +19411,7 @@ static int process_dahdi(struct dahdi_chan_conf *confp, const char *cat, struct
                                        report_alarms = REPORT_SPAN_ALARMS;
                         }
                } else if (!(options & PROC_DAHDI_OPT_NOWARN) )
-                       ast_log(LOG_WARNING, "Ignoring any changes to '%s' (on reload) at line %d.\n", v->name, v->lineno);
+                       ast_log(LOG_NOTICE, "Ignoring any changes to '%s' (on reload) at line %d.\n", v->name, v->lineno);
        }
 
        if (dahdichan) {
index 6ff1896a7e200be45a8d503b8f898aaf0b1c5979..0b58a2b45ba7a29aaf5c8189c849c37defdc2ea3 100644 (file)
@@ -3407,7 +3407,7 @@ static int send_packet(struct iax_frame *f)
 
        /* Called with iaxsl held */
        if (iaxdebug) {
-               ast_debug(3, "Sending %u on %d/%d to %s\n", f->ts, callno, iaxs[callno]->peercallno, ast_sockaddr_stringify(&iaxs[callno]->addr));
+               ast_debug(8, "Sending %u on %d/%d to %s\n", f->ts, callno, iaxs[callno]->peercallno, ast_sockaddr_stringify(&iaxs[callno]->addr));
        }
        if (f->transfer) {
                iax_outputframe(f, NULL, 0, &iaxs[callno]->transfer, f->datalen - sizeof(struct ast_iax2_full_hdr));
@@ -10363,7 +10363,7 @@ static int socket_process_helper(struct iax2_thread *thread)
        }
        if (ast_test_flag64(iaxs[fr->callno], IAX_ENCRYPTED) && !decrypted) {
                if (decrypt_frame(fr->callno, fh, &f, &res)) {
-                       ast_log(LOG_NOTICE, "Packet Decrypt Failed!\n");
+                       ast_log(LOG_WARNING, "Packet Decrypt Failed!\n");
                        ast_variables_destroy(ies.vars);
                        ast_mutex_unlock(&iaxsl[fr->callno]);
                        return 1;
@@ -12033,7 +12033,7 @@ immediatedial:
                iaxs[fr->callno]->last = fr->ts;
 #if 1
                if (iaxdebug)
-                       ast_debug(3, "For call=%d, set last=%u\n", fr->callno, fr->ts);
+                       ast_debug(8, "For call=%d, set last=%u\n", fr->callno, fr->ts);
 #endif
        }
 
index 9645bd6fed088b12826236f60c459973be1e2fda..78a8eb9b43e70b46a44470f6752d9b5d1962092b 100644 (file)
@@ -6204,7 +6204,7 @@ static int match_filter(struct mansession *s, char *eventdata)
        if (manager_debug) {
                ast_verbose("<-- Examining AMI event: -->\n%s\n", eventdata);
        } else {
-               ast_debug(3, "Examining AMI event:\n%s\n", eventdata);
+               ast_debug(4, "Examining AMI event:\n%s\n", eventdata);
        }
        if (!ao2_container_count(s->session->whitefilters) && !ao2_container_count(s->session->blackfilters)) {
                return 1; /* no filtering means match all */
index cf89a9980b16e7579c9d50ccdc6ea99ba977a617..a7cc7e2f1622596cd8d64e32d75e8f3e0adc6e3e 100644 (file)
@@ -2298,7 +2298,7 @@ int stasis_message_type_declined(const char *name)
        ao2_cleanup(name_in_declined);
        ao2_ref(cfg, -1);
        if (res) {
-               ast_log(LOG_NOTICE, "Declining to allocate Stasis message type '%s' due to configuration\n", name);
+               ast_debug(4, "Declining to allocate Stasis message type '%s' due to configuration\n", name);
        }
        return res;
 }
index 38bbecb9cfe4e7131e0d3ce578251fcb0c77ed61..af0e0c937f55910b87bb07bd357cc848e0e099e6 100644 (file)
@@ -742,7 +742,7 @@ static int transport_apply(const struct ast_sorcery *sorcery, void *obj)
                res = PJ_SUCCESS;
        } else if (!transport->allow_reload && perm_state) {
                /* We inherit the transport from perm state, untouched */
-               ast_log(LOG_WARNING, "Transport '%s' is not fully reloadable, not reloading: protocol, bind, TLS, TCP, ToS, or CoS options.\n", transport_id);
+               ast_log(LOG_NOTICE, "Transport '%s' is not fully reloadable, not reloading: protocol, bind, TLS, TCP, ToS, or CoS options.\n", transport_id);
                temp_state->state->transport = perm_state->state->transport;
                perm_state->state->transport = NULL;
                temp_state->state->factory = perm_state->state->factory;
index 14013ade5ae910d3cd220746e73a7e0082db192c..4f4825778908df6db23136bba0619f4e9d86e2d8 100644 (file)
@@ -806,7 +806,7 @@ static void qualify_contact_cb(void *token, pjsip_event *e)
 
        if (ast_sip_push_task(contact_callback_data->aor_options->serializer,
                sip_options_contact_status_notify_task, contact_callback_data)) {
-               ast_log(LOG_NOTICE, "Unable to queue contact status update for '%s' on AOR '%s', state will be incorrect\n",
+               ast_log(LOG_WARNING, "Unable to queue contact status update for '%s' on AOR '%s', state will be incorrect\n",
                        ast_sorcery_object_get_id(contact_callback_data->contact),
                        contact_callback_data->aor_options->name);
                ao2_ref(contact_callback_data, -1);