]> git.ipfire.org Git - thirdparty/wireguard-go.git/commitdiff
conn: do not SO_REUSEADDR on linux
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 18 Dec 2020 15:41:49 +0000 (16:41 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 7 Jan 2021 13:49:44 +0000 (14:49 +0100)
SO_REUSEADDR does not make sense for unicast UDP sockets.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
conn/conn_linux.go

index 08c8949d921b0c79f8d8be9391616aa7e14db66b..ef9810012908d0f294879347b42ca60b952dc9b2 100644 (file)
@@ -326,15 +326,6 @@ func create4(port uint16) (int, uint16, error) {
        // set sockopts and bind
 
        if err := func() error {
-               if err := unix.SetsockoptInt(
-                       fd,
-                       unix.SOL_SOCKET,
-                       unix.SO_REUSEADDR,
-                       1,
-               ); err != nil {
-                       return err
-               }
-
                if err := unix.SetsockoptInt(
                        fd,
                        unix.IPPROTO_IP,
@@ -379,16 +370,6 @@ func create6(port uint16) (int, uint16, error) {
        }
 
        if err := func() error {
-
-               if err := unix.SetsockoptInt(
-                       fd,
-                       unix.SOL_SOCKET,
-                       unix.SO_REUSEADDR,
-                       1,
-               ); err != nil {
-                       return err
-               }
-
                if err := unix.SetsockoptInt(
                        fd,
                        unix.IPPROTO_IPV6,