]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-141808: Don't remove the JIT stencils when building with PGO (#141809)
authorMiro Hrončok <miro@hroncok.cz>
Tue, 9 Dec 2025 12:44:19 +0000 (13:44 +0100)
committerGitHub <noreply@github.com>
Tue, 9 Dec 2025 12:44:19 +0000 (13:44 +0100)
See: https://discuss.python.org/t/building-the-jit-with-pre-built-stencils/91838/12

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Makefile.pre.in
Misc/NEWS.d/next/Build/2025-11-20-23-15-39.gh-issue-141808.NEewZC.rst [new file with mode: 0644]

index 2554114fff6d6c5f0fe2511882a62a0efe7a82bf..6b94e2d88dd035b332bf46df0c2a32b0adca6fdf 100644 (file)
@@ -837,7 +837,7 @@ check-app-store-compliance:
 
 # Profile generation build must start from a clean tree.
 profile-clean-stamp:
-       $(MAKE) clean
+       $(MAKE) clean-profile
        touch $@
 
 # Compile with profile generation enabled.
@@ -3250,7 +3250,6 @@ clean-retain-profile: pycremoval
        -rm -rf Python/deepfreeze
        -rm -f Python/frozen_modules/*.h
        -rm -f Python/frozen_modules/MANIFEST
-       -rm -f jit_stencils*.h
        -find build -type f -a ! -name '*.gc??' -exec rm -f {} ';'
        -rm -f Include/pydtrace_probes.h
        -rm -f profile-gen-stamp
@@ -3269,13 +3268,21 @@ profile-removal:
        rm -f profile-run-stamp
        rm -f profile-bolt-stamp
 
-.PHONY: clean
-clean: clean-retain-profile clean-bolt
+.PHONY: clean-profile
+clean-profile: clean-retain-profile clean-bolt
        @if test @DEF_MAKE_ALL_RULE@ = profile-opt -o @DEF_MAKE_ALL_RULE@ = bolt-opt; then \
                rm -f profile-gen-stamp profile-clean-stamp; \
                $(MAKE) profile-removal; \
        fi
 
+# gh-141808: The JIT stencils are deliberately kept in clean-profile
+.PHONY: clean-jit-stencils
+clean-jit-stencils:
+       -rm -f jit_stencils*.h
+
+.PHONY: clean
+clean: clean-profile clean-jit-stencils
+
 .PHONY: clobber
 clobber: clean
        -rm -f $(BUILDPYTHON) $(LIBRARY) $(LDLIBRARY) $(DLLLIBRARY) \
diff --git a/Misc/NEWS.d/next/Build/2025-11-20-23-15-39.gh-issue-141808.NEewZC.rst b/Misc/NEWS.d/next/Build/2025-11-20-23-15-39.gh-issue-141808.NEewZC.rst
new file mode 100644 (file)
index 0000000..73220e1
--- /dev/null
@@ -0,0 +1,4 @@
+When running ``make clean-retain-profile``, keep the
+generated JIT stencils. That way, the stencils are not generated twice when
+Profile-guided optimization (PGO) is used. It also allows distributors to
+supply their own pre-built JIT stencils.