]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: Remove stray put_device() in pci_register_host_bridge()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 7 Mar 2025 08:46:34 +0000 (11:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:31:59 +0000 (14:31 +0200)
[ Upstream commit 6e8d06e5096c80cbf41313b4a204f43071ca42be ]

This put_device() was accidentally left over from when we changed the code
from using device_register() to calling device_add().  Delete it.

Link: https://lore.kernel.org/r/55b24870-89fb-4c91-b85d-744e35db53c2@stanley.mountain
Fixes: 9885440b16b8 ("PCI: Fix pci_host_bridge struct device release/free handling")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/probe.c

index dd2134c7c4192ba79f49796e376f9a87f3b8f91e..51615e4d28f41dd6228d7a701c91b14d8adfc747 100644 (file)
@@ -926,10 +926,9 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)
                goto free;
 
        err = device_add(&bridge->dev);
-       if (err) {
-               put_device(&bridge->dev);
+       if (err)
                goto free;
-       }
+
        bus->bridge = get_device(&bridge->dev);
        device_enable_async_suspend(bus->bridge);
        pci_set_bus_of_node(bus);