]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
explicitly initalize 'status'
authorAlan T. DeKok <aland@freeradius.org>
Sun, 4 Jan 2026 22:53:55 +0000 (17:53 -0500)
committerAlan T. DeKok <aland@freeradius.org>
Sun, 4 Jan 2026 22:53:55 +0000 (17:53 -0500)
while the common value for uninitialized memory is zero, it doesn't
have to be.  And the code definitely uses status before it is
explicitly initialized.

src/modules/rlm_cache/drivers/rlm_cache_redis/rlm_cache_redis.c

index b23fe6d077db93621741df3d9f2ddeb5e0e4823b..e981a644db9ae7f85267e18cafb360ff9e845680 100644 (file)
@@ -124,7 +124,7 @@ static cache_status_t cache_entry_find(rlm_cache_entry_t **out,
 
        fr_redis_cluster_state_t        state;
        fr_redis_conn_t                 *conn;
-       fr_redis_rcode_t                status;
+       fr_redis_rcode_t                status = REDIS_RCODE_SUCCESS;
        redisReply                      *reply = NULL;
        int                             s_ret;
 
@@ -255,7 +255,7 @@ static cache_status_t cache_entry_insert(UNUSED rlm_cache_config_t const *config
 
        fr_redis_conn_t         *conn;
        fr_redis_cluster_state_t        state;
-       fr_redis_rcode_t        status;
+       fr_redis_rcode_t        status = REDIS_RCODE_SUCCESS;
        redisReply              *reply = NULL;
        int                     s_ret;
 
@@ -430,7 +430,7 @@ static cache_status_t cache_entry_expire(UNUSED rlm_cache_config_t const *config
        rlm_cache_redis_t               *driver = instance;
        fr_redis_cluster_state_t        state;
        fr_redis_conn_t                 *conn;
-       fr_redis_rcode_t                        status;
+       fr_redis_rcode_t                status = REDIS_RCODE_SUCCESS;
        redisReply                      *reply = NULL;
        int                             s_ret;
        cache_status_t                  cache_status;