]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: Match DT helper types
authorRob Herring (Arm) <robh@kernel.org>
Fri, 12 Jun 2026 21:49:38 +0000 (16:49 -0500)
committerLinus Walleij <linusw@kernel.org>
Fri, 12 Jun 2026 22:22:16 +0000 (00:22 +0200)
The affected pinctrl drivers either check for the presence of a standard
property or read a property documented with an 8-bit cell encoding.
Using boolean or u32 helpers for those cases disagrees with the binding.

Use a presence helper for "gpio-ranges" and read
"microchip,spi-present-mask" with the u8 helper documented by the
binding.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
drivers/pinctrl/pinctrl-mcp23s08_spi.c

index 8c353676f2afb6322b0ff5075bf3d8402ed0689b..e20f7dc79d43e1c9aea17d88e3b37170c9979aa7 100644 (file)
@@ -868,7 +868,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
        gc->set = iproc_gpio_set;
        gc->get = iproc_gpio_get;
 
-       chip->pinmux_is_supported = of_property_read_bool(dev->of_node,
+       chip->pinmux_is_supported = of_property_present(dev->of_node,
                                                        "gpio-ranges");
 
        /* optional GPIO interrupt support */
index 54f61c8cb1c0f360b580043e30c40616c5cec65d..76d4c135db116c1dded8bbf5c5a156f972070214 100644 (file)
@@ -143,13 +143,13 @@ static int mcp23s08_probe(struct spi_device *spi)
        unsigned int addr;
        int chips;
        int ret;
-       u32 v;
+       u8 v;
 
        info = spi_get_device_match_data(spi);
 
-       ret = device_property_read_u32(dev, "microchip,spi-present-mask", &v);
+       ret = device_property_read_u8(dev, "microchip,spi-present-mask", &v);
        if (ret) {
-               ret = device_property_read_u32(dev, "mcp,spi-present-mask", &v);
+               ret = device_property_read_u8(dev, "mcp,spi-present-mask", &v);
                if (ret) {
                        dev_err(dev, "missing spi-present-mask");
                        return ret;