]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
x86: edison: Avoid passing FORCE to the align command
authorSimon Glass <sjg@chromium.org>
Sat, 13 Jun 2026 13:05:12 +0000 (07:05 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 15 Jun 2026 18:49:56 +0000 (12:49 -0600)
Commit bd3f9ee679b4 ("kbuild: Bump the build system to 6.1") adds FORCE
as a prerequisite to the u-boot-align.bin rule, but cmd_mkalign_eds
expands $^, so FORCE leaks in as a stray operand. The dd then fails
(silently, since its stderr is discarded) and the following mv never
runs, so u-boot.bin never gains its 4096-byte zero prefix. The mask ROM
enters U-Boot 0x1000 (4KB) into the image and the board never starts,
sitting in BootROM download mode (DnX).

Use $< instead of $^, which excludes FORCE and restores the prefix.

Fixes: bd3f9ee679b4 ("kbuild: Bump the build system to 6.1")
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
board/intel/edison/config.mk

index 3afebf0f0b1e79fa9e0cd58345522547783bb2e0..fff187caa15482d68da86143f6f7a9efe32a3e84 100644 (file)
@@ -7,8 +7,8 @@
 # Add 4096 bytes of zeroes to u-boot.bin
 quiet_cmd_mkalign_eds = EDSALGN $@
 cmd_mkalign_eds =                                                      \
-       dd if=$^ of=$@ bs=4k seek=1 2>/dev/null &&                      \
-       mv $@ $^
+       dd if=$< of=$@ bs=4k seek=1 2>/dev/null &&                      \
+       mv $@ $<
 
 INPUTS-y += u-boot-align.bin
 u-boot-align.bin: u-boot.bin FORCE