]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: imx8mn-vhip4-evalboard-v1: Correct interrupt flags
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Mon, 6 Apr 2026 06:38:11 +0000 (08:38 +0200)
committerFrank Li <Frank.Li@nxp.com>
Tue, 5 May 2026 19:26:48 +0000 (15:26 -0400)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 => IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 => IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted the
same logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW

Fixes: 5eb7405db99b ("arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Marek Vasut <marex@nabladev.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1.dts

index 5f37065bf43f3835b2962306a909428b7a72b1de..a8f7c226a61f86addeacdb5f849932e98809a8dd 100644 (file)
 
 &ifm_pmic {
        interrupt-parent = <&gpio2>;
-       interrupts = <0 GPIO_ACTIVE_LOW>;
+       interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
 };
 
 &iomuxc {