]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
drsblobs.idl: use dom_sid0 in ForestTrustDataDomainInfo
authorStefan Metzmacher <metze@samba.org>
Tue, 17 Dec 2024 16:49:52 +0000 (17:49 +0100)
committerStefan Metzmacher <metze@samba.org>
Sat, 8 Feb 2025 18:48:35 +0000 (18:48 +0000)
We already use ndr_size_dom_sid0() and when ForestTrustDataDomainInfo
is used as part of ForestTrustDataScannerInfo, sid_size is 0
and the subcontext for the sid is skipped.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
librpc/idl/drsblobs.idl
selftest/knownfail.d/samba4.local.ndr [deleted file]

index b4f053dc19725f9fa68f0b52e2c296c63f50136d..dd78c8f2f92736743b861903e048fc5f93c6e457 100644 (file)
@@ -613,7 +613,7 @@ interface drsblobs {
 
        typedef [flag(NDR_NOALIGN)] struct {
                [value(ndr_size_dom_sid0(&sid, ndr->flags))] uint32 sid_size;
-               [subcontext(0),subcontext_size(sid_size)] dom_sid sid;
+               [subcontext(0),subcontext_size(sid_size)] dom_sid0 sid;
                ForestTrustString dns_name;
                ForestTrustString netbios_name;
        } ForestTrustDataDomainInfo;
diff --git a/selftest/knownfail.d/samba4.local.ndr b/selftest/knownfail.d/samba4.local.ndr
deleted file mode 100644 (file)
index a81b52e..0000000
+++ /dev/null
@@ -1 +0,0 @@
-^samba4.local.ndr.*.drsblobs.ForestTrustInfo_with_scanner.forest_trust_info_check_out2