net: dsa: mt7530: set CPU port to fallback mode

commit 38152ea37d8bdaffa22603e0a5b5b86cfa8714c9 upstream.

Currently, setting a bridge's self PVID to other value and deleting
the default VID 1 renders untagged ports of that VLAN unable to talk to
the CPU port:

	bridge vlan add dev br0 vid 2 pvid untagged self
	bridge vlan del dev br0 vid 1 self
	bridge vlan add dev sw0p0 vid 2 pvid untagged
	bridge vlan del dev sw0p0 vid 1
	# br0 cannot send untagged frames out of sw0p0 anymore

That is because the CPU port is set to security mode and its PVID is
still 1, and untagged frames are dropped due to VLAN member violation.

Set the CPU port to fallback mode so untagged frames can pass through.

Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index b95425a63a13458c07d3a6f0543c373b17c48438..797dc48536ccd46e0c017dc879d1dc0ec4b7e359 100644 (file)
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -818,10 +818,15 @@ mt7530_port_set_vlan_aware(struct dsa_switch *ds, int port)
                   PCR_MATRIX_MASK, PCR_MATRIX(MT7530_ALL_MEMBERS));
 
        /* Trapped into security mode allows packet forwarding through VLAN
-        * table lookup.
+        * table lookup. CPU port is set to fallback mode to let untagged
+        * frames pass through.
         */
-       mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
-                  MT7530_PORT_SECURITY_MODE);
+       if (dsa_is_cpu_port(ds, port))
+               mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
+                          MT7530_PORT_FALLBACK_MODE);
+       else
+               mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
+                          MT7530_PORT_SECURITY_MODE);
 
        /* Set the port as a user port which is to be able to recognize VID
         * from incoming packets before fetching entry within the VLAN table.

diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h
index 0e7e36d8f994349672279b235cccf8206d9ea002..3ef7b5a6fc227d42403d0fe56e5e745c8c6f196b 100644 (file)
--- a/drivers/net/dsa/mt7530.h
+++ b/drivers/net/dsa/mt7530.h
@@ -148,6 +148,12 @@ enum mt7530_port_mode {
        /* Port Matrix Mode: Frames are forwarded by the PCR_MATRIX members. */
        MT7530_PORT_MATRIX_MODE = PORT_VLAN(0),
 
+       /* Fallback Mode: Forward received frames with ingress ports that do
+        * not belong to the VLAN member. Frames whose VID is not listed on
+        * the VLAN table are forwarded by the PCR_MATRIX members.
+        */
+       MT7530_PORT_FALLBACK_MODE = PORT_VLAN(1),
+
        /* Security Mode: Discard any frame due to ingress membership
         * violation or VID missed on the VLAN table.
         */