]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: gpib: struct typing for gpib_board
authorMichael Rubin <matchstick@neverthere.org>
Wed, 19 Mar 2025 21:59:05 +0000 (21:59 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 13:57:24 +0000 (06:57 -0700)
Using Linux code style for gpib_board struct in .h to allow drivers to migrate.

Adhering to Linux code style.

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Acked-By: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250319215924.19387-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/include/gpib_types.h

index b41781a55a60e14a2ca39ecaaa51c18a0f4aa910..7dc5a16e427b2a3b223382838259b4e939592853 100644 (file)
@@ -23,7 +23,7 @@
 #include <linux/interrupt.h>
 
 typedef struct gpib_interface_struct gpib_interface_t;
-typedef struct gpib_board_struct gpib_board_t;
+typedef struct gpib_board gpib_board_t;
 
 /* config parameters that are only used by driver attach functions */
 typedef struct {
@@ -220,7 +220,7 @@ typedef struct gpib_interface_list_struct {
  * It provides storage for variables local to each board, and interface
  * functions for performing operations on the board
  */
-struct gpib_board_struct {
+struct gpib_board {
        /* functions used by this board */
        gpib_interface_t *interface;
        /* Pointer to module whose use count we should increment when