]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
server/tcp: tiny refactoring
authorLibor Peltan <libor.peltan@nic.cz>
Wed, 14 Feb 2024 15:00:05 +0000 (16:00 +0100)
committerDaniel Salzman <daniel.salzman@nic.cz>
Tue, 7 May 2024 05:52:29 +0000 (07:52 +0200)
src/knot/common/fdset.c
src/knot/server/tcp-handler.c

index a0a02127270094d812c954396966c3af9c7ad725..548bed2b227e3453ac1ee45d645fbc9dc9f78c1d 100644 (file)
@@ -326,8 +326,7 @@ void fdset_sweep(fdset_t *set, const fdset_sweep_cb_t cb, void *data)
        while (idx < set->n) {
                /* Check sweep state, remove if requested. */
                if (set->timeout[idx] > 0 && set->timeout[idx] <= now.tv_sec) {
-                       const int fd = fdset_get_fd(set, idx);
-                       if (cb(set, fd, data) == FDSET_SWEEP) {
+                       if (cb(set, idx, data) == FDSET_SWEEP) {
                                (void)fdset_remove(set, idx);
                                continue;
                        }
index 1f32f0e562aeec3a618c8407453636e554956a57..b2866281e8a94ebd8de3d09c8b1099e43dc57885 100644 (file)
@@ -79,8 +79,9 @@ static void update_tcp_conf(tcp_context_t *tcp)
 }
 
 /*! \brief Sweep TCP connection. */
-static fdset_sweep_state_t tcp_sweep(fdset_t *set, int fd, _unused_ void *data)
+static fdset_sweep_state_t tcp_sweep(fdset_t *set, int idx, _unused_ void *data)
 {
+       const int fd = fdset_get_fd(set, idx);
        assert(set && fd >= 0);
 
        /* Best-effort, name and shame. */