]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Rename _detachEvents method to better describe it's behaviour. 9278/head
authorMilos Sakovic <m@deva.co>
Tue, 1 Nov 2016 16:36:51 +0000 (17:36 +0100)
committerMilos Sakovic <m@deva.co>
Tue, 1 Nov 2016 16:36:51 +0000 (17:36 +0100)
js/foundation.orbit.js

index 2ca922dde612abb2a7ed114e28d128f9c5051d71..c07e5f03a1e7f48ef906668c52ed29b2cc5a79c2 100644 (file)
@@ -43,7 +43,8 @@ class Orbit {
   * @private
   */
   _init() {
-    this._detachEvents();
+    // @TODO: consider discussion on PR #9278 about DOM pollution by changeSlide
+    this._reset();
 
     this.$wrapper = this.$element.find(`.${this.options.containerClass}`);
     this.$slides = this.$element.find(`.${this.options.slideClass}`);
@@ -241,9 +242,9 @@ class Orbit {
   }
 
   /**
-   * Detaches event listeners
+   * Resets Orbit so it can be reinitialized
    */
-  _detachEvents() {
+  _reset() {
     // Don't do anything if there are no slides (first run)
     if (typeof this.$slides == 'undefined') {
       return;