[#947] addressed review

diff --git a/src/hooks/dhcp/flex_option/flex_option.dox b/src/hooks/dhcp/flex_option/flex_option.dox
index 274b745a5bfe60420487ea4750188837f34f5515..3ff81f47a7796293a07acccea3c1a00156321ed0 100644 (file)
--- a/src/hooks/dhcp/flex_option/flex_option.dox
+++ b/src/hooks/dhcp/flex_option/flex_option.dox
@@ -112,7 +112,7 @@ applied by the template @c process located in flex_option.h. When
 required the expression is evaluated on the query packet and the result
 is used by the action for instance to add a new option.
 
-@section libdhcp_flex_optionMTCompatibility Multi-Threading Compaibility
+@section libdhcp_flex_optionMTCompatibility Multi-Threading Compatibility
 
 The libdhcp_flex_option hooks library is compatible with multi-threading.
 

diff --git a/src/hooks/dhcp/flex_option/flex_option_callouts.cc b/src/hooks/dhcp/flex_option/flex_option_callouts.cc
index 2f3f88dd946f5aea55bb3fa0f2572ef584693a0f..b6688e036281c9ab58d63365ac1ba4150c223704 100644 (file)
--- a/src/hooks/dhcp/flex_option/flex_option_callouts.cc
+++ b/src/hooks/dhcp/flex_option/flex_option_callouts.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2019-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the End User License
 // Agreement. See COPYING file in the premium/ directory.
@@ -122,7 +122,7 @@ int unload() {
     return (0);
 }
 
-/// @brief This function is called to know the multi-threading compatibility.
+/// @brief This function is called to retrieve the multi-threading compatibility.
 ///
 /// @return 1 which means compatible with multi-threading.
 int multi_threading_compatible() {

diff --git a/src/hooks/dhcp/high_availability/ha.dox b/src/hooks/dhcp/high_availability/ha.dox
index f905c135c408daca5e8309a0977164863d3c2b2f..0c2735517344f84d46a83e9860feefa42fe98221 100644 (file)
--- a/src/hooks/dhcp/high_availability/ha.dox
+++ b/src/hooks/dhcp/high_availability/ha.dox
@@ -1,4 +1,4 @@
-// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -411,6 +411,6 @@ Addressing this issue requires two enhancements:
 
 The High Availability hooks library currently reports it is not
 compatible with multi-threading. This will be revisited as there is
-no essential reason for such uncompatibility.
+no essential reason for such incompatibility.
 
 */

diff --git a/src/hooks/dhcp/high_availability/ha_callouts.cc b/src/hooks/dhcp/high_availability/ha_callouts.cc
index 0bffd99de260be948c36d4dc34a18880b8508e35..b8e8da4a6edd684f04191a4c43d608ff9b8bd4cb 100644 (file)
--- a/src/hooks/dhcp/high_availability/ha_callouts.cc
+++ b/src/hooks/dhcp/high_availability/ha_callouts.cc
@@ -303,10 +303,10 @@ int unload() {
     return (0);
 }
 
-/// @brief This function is called to know the multi-threading compatibility.
+/// @brief This function is called to retrieve the multi-threading compatibility.
 ///
 /// @note: this should be revisited as the library is not essentially
-/// uncompatible.
+/// incompatible.
 ///
 /// @return 0 which means not compatible with multi-threading.
 int multi_threading_compatible() {

diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds.dox b/src/hooks/dhcp/lease_cmds/lease_cmds.dox
index b12f71dcc2439068d8ea16079b6cf925901236c1..9c69e1c55cf7e9e8ffe9f9b8858b3ae9eb38f98e 100644 (file)
--- a/src/hooks/dhcp/lease_cmds/lease_cmds.dox
+++ b/src/hooks/dhcp/lease_cmds/lease_cmds.dox
@@ -1,4 +1,4 @@
-// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -95,10 +95,9 @@ commands that remove all leases from specific subnet. As there were no
 queries that could retrieve or otherwise enumerate leases for a specific subnet,
 a new query type and a new index had to be added.
 
-@section lease_cmdsTCompatibility Multi-Threading Compatibility
+@section lease_cmdsMTCompatibility Multi-Threading Compatibility
 
 The Lease Commands Hook library is compatible with multi-threading.
-All commands modifying leases are performed inside a critical section
-i.e. with the DHCP server stopped.
+All commands are executed inside a critical section, i.e. with threads stopped.
 
 */

diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds_callouts.cc b/src/hooks/dhcp/lease_cmds/lease_cmds_callouts.cc
index 02c1ec35fc4c3fc098d8b5f926f9c61c05029c11..f2612562132792c1d72839fbdcacf4174f473275 100644 (file)
--- a/src/hooks/dhcp/lease_cmds/lease_cmds_callouts.cc
+++ b/src/hooks/dhcp/lease_cmds/lease_cmds_callouts.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the End User License
 // Agreement. See COPYING file in the premium/ directory.
@@ -284,7 +284,7 @@ int unload() {
     return (0);
 }
 
-/// @brief This function is called to know the multi-threading compatibility.
+/// @brief This function is called to retrieve the multi-threading compatibility.
 ///
 /// @return 1 which means compatible with multi-threading.
 int multi_threading_compatible() {

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_callouts.cc b/src/hooks/dhcp/mysql_cb/mysql_cb_callouts.cc
index 7140621b6b3a5fef9c30d343321fd87765d3d656..100b663081fbe4b169060c59973ea287ea50b1f1 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_callouts.cc
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_callouts.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -45,7 +45,7 @@ int unload() {
     return (0);
 }
 
-/// @brief This function is called to know the multi-threading compatibility.
+/// @brief This function is called to retrieve the multi-threading compatibility.
 ///
 /// @note: the compatibility is based on the assumption this hook library
 /// is always called from the main thread.

diff --git a/src/hooks/dhcp/stat_cmds/stat_cmds.cc b/src/hooks/dhcp/stat_cmds/stat_cmds.cc
index f99c7b79412455c3f08fd34570996dcb73235e09..85c07436b3a89e64efb113461d4bf4f6f5f2ed10 100644 (file)
--- a/src/hooks/dhcp/stat_cmds/stat_cmds.cc
+++ b/src/hooks/dhcp/stat_cmds/stat_cmds.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/hooks/dhcp/stat_cmds/stat_cmds.dox b/src/hooks/dhcp/stat_cmds/stat_cmds.dox
index 34ac249ad221d2e4f503c6b3c776b336904cf29a..f4f2db3b64deefd3a0035d97aece6daf1fb5b633 100644 (file)
--- a/src/hooks/dhcp/stat_cmds/stat_cmds.dox
+++ b/src/hooks/dhcp/stat_cmds/stat_cmds.dox
@@ -198,9 +198,8 @@ and DHCPv6 response might look like this:
 
 @section stat_cmdsMTCompatibility Multi-Threading Compatibility
 
-The Stat Commands Hook library reports it is compatible with
-multi-threading. All commands are executed inside a critical section,
-i.e. with threads stopped. It makes sense to not have lease state
-changes when taking lease counts.
+The Stat Commands Hook library is compatible with multi-threading.
+All commands are executed inside a critical section, i.e. with threads stopped.
+It makes sense to not have lease state changes when retrieving lease counts.
 
 */

diff --git a/src/hooks/dhcp/stat_cmds/stat_cmds_callouts.cc b/src/hooks/dhcp/stat_cmds/stat_cmds_callouts.cc
index ea8026124f0d76bad3da7a57b2d07952fc9492a8..480b7cb67567d8f1151fdc77fe94086d997be64b 100644 (file)
--- a/src/hooks/dhcp/stat_cmds/stat_cmds_callouts.cc
+++ b/src/hooks/dhcp/stat_cmds/stat_cmds_callouts.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the End User License
 // Agreement. See COPYING file in the premium/ directory.
@@ -61,7 +61,7 @@ int unload() {
     return (0);
 }
 
-/// @brief This function is called to know the multi-threading compatibility.
+/// @brief This function is called to retrieve the multi-threading compatibility.
 ///
 /// @return 1 which means compatible with multi-threading.
 int multi_threading_compatible() {

diff --git a/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox b/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
index 4b3534252ab41d383d8d3cdcd3291fa10af48eab..84dc9429014a0a68da40aab94612f8f9fc282ec3 100644 (file)
--- a/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
+++ b/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -212,7 +212,7 @@ registered=yes
 
 Note the library always opens this file in append mode and does not limit its size.
 
-@section libdhcp_user_chkMTCompatibility Multi-Threading Compaibility
+@section libdhcp_user_chkMTCompatibility Multi-Threading Compatibility
 
 The user_chk hooks library does not define a multi_threading_compatible()
 C function so is considered as not compatible with multi-threading

diff --git a/src/lib/hooks/library_manager.cc b/src/lib/hooks/library_manager.cc
index 608c4c59106a3af9225a02c0dc080bdd92c369f4..b18dcbf92ef4994fd792450e2dd30328f4ac4119 100644 (file)
--- a/src/lib/hooks/library_manager.cc
+++ b/src/lib/hooks/library_manager.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/lib/hooks/library_manager.h b/src/lib/hooks/library_manager.h
index 14acf8a64dd3986c356a444279b7eb3855e0678a..ef313335899fa40de6e841c0cb6e5af78827ceec 100644 (file)
--- a/src/lib/hooks/library_manager.h
+++ b/src/lib/hooks/library_manager.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/lib/hooks/tests/full_callout_library.cc b/src/lib/hooks/tests/full_callout_library.cc
index 8d3784d70856ba78b2e42f7fbd677eab8502ff78..58ea8c77f45fd66306f68507f3ce5ae4e97266f8 100644 (file)
--- a/src/lib/hooks/tests/full_callout_library.cc
+++ b/src/lib/hooks/tests/full_callout_library.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/lib/hooks/tests/library_manager_unittest.cc b/src/lib/hooks/tests/library_manager_unittest.cc
index 78f3c0cff059368685cedabfd155b985f82ecb9b..7408c6284154b85bef4033c9ef29cdf4b0811db1 100644 (file)
--- a/src/lib/hooks/tests/library_manager_unittest.cc
+++ b/src/lib/hooks/tests/library_manager_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/lib/hooks/tests/load_error_callout_library.cc b/src/lib/hooks/tests/load_error_callout_library.cc
index 26f0d9e2b6a549920d0aec60e9833d7a9bc9e731..66b1359031ad17bce4b43fa977c5341c565ba0a9 100644 (file)
--- a/src/lib/hooks/tests/load_error_callout_library.cc
+++ b/src/lib/hooks/tests/load_error_callout_library.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this