]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
misc: hisi_hikey_usb: Use str_enabled_disabled() in hub_power_ctrl()
authorThorsten Blum <thorsten.blum@linux.dev>
Wed, 13 Aug 2025 18:01:08 +0000 (20:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Aug 2025 10:37:15 +0000 (12:37 +0200)
Remove hard-coded strings by using the str_enabled_disabled() helper
function and silence the following Coccinelle/coccicheck warning
reported by string_choices.cocci:

  opportunity for str_enabled_disabled(value)

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Acked-by: John Stultz <jstultz@google.com>
Link: https://lore.kernel.org/r/20250813180108.209096-2-thorsten.blum@linux.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/hisi_hikey_usb.c

index ffe7b945a29857d42a73f6ea01c623f1f108f7fe..2c6e448a47f11b435fe74f4d0ffedb77348a8d2d 100644 (file)
@@ -18,6 +18,7 @@
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
+#include <linux/string_choices.h>
 #include <linux/usb/role.h>
 
 #define DEVICE_DRIVER_NAME "hisi_hikey_usb"
@@ -67,7 +68,7 @@ static void hub_power_ctrl(struct hisi_hikey_usb *hisi_hikey_usb, int value)
        if (ret)
                dev_err(hisi_hikey_usb->dev,
                        "Can't switch regulator state to %s\n",
-                       value ? "enabled" : "disabled");
+                       str_enabled_disabled(value));
 }
 
 static void usb_switch_ctrl(struct hisi_hikey_usb *hisi_hikey_usb,