gpio: bd71828: use new line value setter callbacks

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/20250310-gpiochip-set-conversion-v1-4-03798bb833eb@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
index b2ccc320c7b53e77f4f3c06bfab37e881d8262b9..4ba151e5cf25b0919bb93ffe6432679a53014fd9 100644 (file)
--- a/drivers/gpio/gpio-bd71828.c
+++ b/drivers/gpio/gpio-bd71828.c
@@ -16,10 +16,9 @@ struct bd71828_gpio {
        struct gpio_chip gpio;
 };
 
-static void bd71828_gpio_set(struct gpio_chip *chip, unsigned int offset,
-                            int value)
+static int bd71828_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                           int value)
 {
-       int ret;
        struct bd71828_gpio *bdgpio = gpiochip_get_data(chip);
        u8 val = (value) ? BD71828_GPIO_OUT_HI : BD71828_GPIO_OUT_LO;
 
@@ -28,12 +27,10 @@ static void bd71828_gpio_set(struct gpio_chip *chip, unsigned int offset,
         * we are dealing with - then we are done
         */
        if (offset == HALL_GPIO_OFFSET)
-               return;
+               return 0;
 
-       ret = regmap_update_bits(bdgpio->regmap, GPIO_OUT_REG(offset),
-                                BD71828_GPIO_OUT_MASK, val);
-       if (ret)
-               dev_err(bdgpio->dev, "Could not set gpio to %d\n", value);
+       return regmap_update_bits(bdgpio->regmap, GPIO_OUT_REG(offset),
+                                 BD71828_GPIO_OUT_MASK, val);
 }
 
 static int bd71828_gpio_get(struct gpio_chip *chip, unsigned int offset)
@@ -112,7 +109,7 @@ static int bd71828_probe(struct platform_device *pdev)
        bdgpio->gpio.set_config = bd71828_gpio_set_config;
        bdgpio->gpio.can_sleep = true;
        bdgpio->gpio.get = bd71828_gpio_get;
-       bdgpio->gpio.set = bd71828_gpio_set;
+       bdgpio->gpio.set_rv = bd71828_gpio_set;
        bdgpio->gpio.base = -1;
 
        /*