]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Drop unused param from xe_device_create()
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 26 May 2026 19:54:47 +0000 (21:54 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 27 May 2026 10:51:22 +0000 (12:51 +0200)
We never used or need anything from the struct pci_device_id there.
And while around, add simple kernel-doc for this function.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://patch.msgid.link/20260526195452.20545-3-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_device.c
drivers/gpu/drm/xe/xe_device.h
drivers/gpu/drm/xe/xe_pci.c

index 576095cf0952901afc1d89c8b1ed631b28385063..3f063e5530bbc548478f3e5a5d5e260aa7ecdd57 100644 (file)
@@ -475,8 +475,15 @@ static void xe_device_destroy(struct drm_device *dev, void *dummy)
        ttm_device_fini(&xe->ttm);
 }
 
-struct xe_device *xe_device_create(struct pci_dev *pdev,
-                                  const struct pci_device_id *ent)
+/**
+ * xe_device_create() - Create a new &xe_device instance
+ * @pdev: the parent &pci_dev
+ *
+ * Allocate and initialize a device managed Xe device structure.
+ *
+ * Return: pointer to new &xe_device on success, or ERR_PTR on failure.
+ */
+struct xe_device *xe_device_create(struct pci_dev *pdev)
 {
        const struct drm_driver *driver = &regular_driver;
        struct xe_device *xe;
index 355d69dc8f5454dec17dd7ec316dbc34666ec29b..27cd2329b99f6b67610c4b024d1d3f45950b5c15 100644 (file)
@@ -43,8 +43,7 @@ static inline struct xe_device *ttm_to_xe_device(struct ttm_device *ttm)
        return container_of(ttm, struct xe_device, ttm);
 }
 
-struct xe_device *xe_device_create(struct pci_dev *pdev,
-                                  const struct pci_device_id *ent);
+struct xe_device *xe_device_create(struct pci_dev *pdev);
 int xe_device_probe_early(struct xe_device *xe);
 int xe_device_probe(struct xe_device *xe);
 void xe_device_remove(struct xe_device *xe);
index 0095a2d7efa49a7406c0e64055feb8b8d8d2cd74..b368bb190fc473f21e43f88f9c4d55dfa6773eca 100644 (file)
@@ -1093,7 +1093,7 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        if (err)
                return err;
 
-       xe = xe_device_create(pdev, ent);
+       xe = xe_device_create(pdev);
        if (IS_ERR(xe))
                return PTR_ERR(xe);